GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat(cli): Add recommendation template for feast init by doc-johnson · Pull Request #6078 · feast-dev/feast

Conversation

doc-johnson commented Mar 8, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Covers point 3 from #5478: a recommendation template for feast init.

The template creates a small product catalog with deterministic 384-dimensional placeholder vectors. Initialization works in the standard Feast environment without installing an ML package or downloading a model.

test_workflow.py loads all-MiniLM-L6-v2 only when the demo is run, replaces the placeholder vectors, applies the repo, materializes the data, runs a top-k query with retrieve_online_documents_v2, and tears the repo down. The online store is local SQLite with vector search enabled, and product_id is included in the requested result fields.

The unit test calls init_repo(..., template="recommendation") and verifies the generated config, feature definitions, parquet data, vector dimensions, and bootstrap cleanup. The targeted test and Ruff pass locally.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

doc-johnson requested a review from a team as a code owner

March 8, 2026 19:50

devin-ai-integration Bot reviewed

Mar 8, 2026

View reviewed changes

devin-ai-integration Bot left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

doc-johnson force-pushed the feat/recommendation-template branch from d9af218 to df3427d Compare

March 9, 2026 12:25


          feat(cli): Add recommendation template for feast init (feast-dev#5478)

Add a new "recommendation" template demonstrating product recommendations
using vector similarity search with pre-computed embeddings (all-MiniLM-L6-v2)
and SQLite online store with vector_enabled.

Signed-off-by: doc-johnson <[email protected]>

doc-johnson force-pushed the feat/recommendation-template branch from 1fb6e6b to 7478002 Compare

June 26, 2026 09:21

franciscojavierarceo and others added 7 commits

July 8, 2026 12:48


          Merge branch 'master' into feat/recommendation-template

34996fa


          Merge remote-tracking branch 'upstream/master' into feat/recommendati…

9e52058

…on-template


          test: Add recommendation template artifacts test

7335fac

Signed-off-by: doc-johnson <[email protected]>


          Merge remote-tracking branch 'upstream/master' into feat/recommendati…

edbff11

…on-template


          Merge branch 'master' into feat/recommendation-template

8be3517


          Merge branch 'master' into feat/recommendation-template

dce09f2


          Merge branch 'master' into feat/recommendation-template

bdd4089

franciscojavierarceo requested a lite review from Copilot

August 15, 2026 11:16

Copilot started reviewing on behalf of franciscojavierarceo

August 15, 2026 11:17

View session

Copilot AI reviewed

Aug 15, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new feast init template (recommendation) that scaffolds a small product-recommendation demo using vector similarity search backed by a local SQLite online store (with vector search enabled). This extends Feast’s CLI templates with a concrete end-to-end example for vector retrieval.

Changes:

Adds a new sdk/python/feast/templates/recommendation/ template with bootstrap data generation (embeddings), feature definitions, local SQLite config, and an end-to-end demo script.
Registers the recommendation template in the CLI --template choices.
Adds a unit test to validate the presence of key template artifacts and vector-search-related configuration.

Reviewed changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
sdk/python/tests/unit/local_feast_tests/test_init.py	Adds assertions that the `recommendation` template exists and is configured for SQLite vector search.
sdk/python/feast/templates/recommendation/bootstrap.py	Bootstraps a small product catalog and writes precomputed embeddings to parquet; fills template placeholders.
sdk/python/feast/templates/recommendation/feature_repo/feature_definitions.py	Defines the entity/FeatureView with a vector-indexed embedding field and a FeatureService.
sdk/python/feast/templates/recommendation/feature_repo/feature_store.yaml	Configures a local SQLite online store with `vector_enabled: true`.
sdk/python/feast/templates/recommendation/feature_repo/test_workflow.py	End-to-end demo script: apply, materialize, vector similarity query via `retrieve_online_documents_v2`, teardown.
sdk/python/feast/templates/recommendation/init.py	Adds package marker for the new template directory.
sdk/python/feast/templates/recommendation/feature_repo/init.py	Adds package marker for the template feature repo.
sdk/python/feast/cli/cli.py	Adds `recommendation` to the accepted `feast init --template` values.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

sdk/python/feast/templates/recommendation/feature_repo/test_workflow.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

haoxu0 requested changes

Aug 16, 2026

View reviewed changes

haoxu0 left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feast init should not require an optional ML package or download a model. The bootstrap imports sentence_transformers and loads all-MiniLM-L6-v2 during initialization, so a normal Feast installation can fail after partially creating the repository; even feast[rag] still depends on network/model-cache availability.

Please ship small precomputed embeddings, generate deterministic placeholder vectors as the existing RAG template does, or defer model installation/loading to test_workflow.py. The test should invoke init_repo(..., template="recommendation") in the standard test environment and verify initialization completes, rather than only checking that template files exist.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

doc-johnson added 3 commits

August 17, 2026 16:22


          Merge remote-tracking branch 'upstream/master' into feat/recommendati…

…on-template

Signed-off-by: doc-johnson <[email protected]>


          fix(cli): Make recommendation template initialization self-contained

Signed-off-by: doc-johnson <[email protected]>


          Merge remote-tracking branch 'upstream/master' into feat/recommendati…

2ff60bc

…on-template

Signed-off-by: doc-johnson <[email protected]>

doc-johnson commented Aug 18, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Author

Updated in 4911874.

feast init now writes deterministic 384-dimensional placeholder vectors and does not import sentence-transformers or download a model. The explicit demo loads all-MiniLM-L6-v2 and replaces the placeholders before apply and materialization.

The test now calls init_repo(..., template="recommendation") and checks the generated repo and parquet vectors. I also added product_id to the requested retrieval fields.

The targeted init test and Ruff pass locally.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

doc-johnson added 2 commits

August 18, 2026 16:29


          Merge branch 'master' into feat/recommendation-template

ea79119


          Merge branch 'master' into feat/recommendation-template

db99b69

codecov-commenter commented Aug 19, 2026

Copy link

Copy Markdown

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.02%. Comparing base (6a4690a) to head (db99b69).
⚠️ Report is 1 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6078      +/-   ##
==========================================
+ Coverage   46.96%   47.02%   +0.06%     
==========================================
  Files         418      418              
  Lines       51675    51675              
  Branches     7485     7485              
==========================================
+ Hits        24268    24300      +32     
+ Misses      25673    25635      -38     
- Partials     1734     1740       +6

Flag	Coverage Δ		*Carryforward flag
go-feature-server	`30.58% <ø> (ø)`		Carriedforward from 6a4690a
python-unit	`48.33% <ø> (+0.06%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
sdk/python/feast/cli/cli.py	`55.17% <ø> (ø)`

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a4690a...db99b69. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          fix: Refresh secret scan baseline

82e4bcb

Signed-off-by: doc-johnson <[email protected]>

ryota717 mentioned this pull request

Sep 29, 2026

Feat: local template odfv write #6892

Open

This branch has not been deployed

No deployments

Reviewers

devin-ai-integration[bot]

devin-ai-integration[bot] left review comments

Copilot code review Copilot

Copilot review effort

Applies to this pull request for everyone.Learn more about Copilot code review.

Copilot left review comments

haoxu0

haoxu0 requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

doc-johnson commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

haoxu0 left a comment

Choose a reason for hiding this comment

Uh oh!

doc-johnson commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Aug 19, 2026

Codecov Report

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

doc-johnson commented Mar 8, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

doc-johnson commented Aug 18, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.