GeezerVison is showing github.com — feat: Replace ORJSONResponse with Pydantic response models for faster JSON serialization by ntkathole · Pull Request #6142 · feast-dev/feast
Conversation
ntkathole
commented
Mar 23, 2026
•
edited by devin-ai-integration
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
What this PR does / why we need it:
- Replace
ORJSONResponse with Pydantic response_model on /get-online-features and /retrieve-online-documents endpoints, leveraging FastAPI's native Rust-based JSON serialization via Pydantic V2 for optimal performance
- Remove
orjson as a direct dependency from pyproject.toml (and regenerated lock files)
- Fix Pixi deprecation warning by replacing
[project] with [workspace] in infra/scripts/pixi/pixi.toml
FastAPI docs recommend using Pydantic response_model over custom response classes like ORJSONResponse for JSON serialization performance:
With response_model, FastAPI serializes directly to JSON bytes via Pydantic's Rust-based serializer skipping the jsonable_encoder intermediate step that ORJSONResponse still required. Pydantic V2 uses the same underlying Rust mechanisms as orjson, so this is at least as fast while also providing automatic response validation and OpenAPI schema documentation.
Which issue(s) this PR fixes:
Fixes #6139
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
ORJSONResponse is deprecated
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.