GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: Add DocEmbedder documentation for PR #5973 by patelchaitany · Pull Request #6201 · feast-dev/feast

Conversation

@patelchaitany

@patelchaitany patelchaitany commented Mar 31, 2026 •
edited by devin-ai-integration Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Summary

  • Added DocEmbedder documentation to docs/getting-started/genai.md covering key components, quick example, and features
  • Added a full "Alternative: Using DocEmbedder" section to docs/tutorials/rag-with-docling.md with setup, retrieval, and detailed customization examples (custom chunker, embedder, and logical layer function)
  • Added DocEmbedder section to examples/rag-retriever/README.md with quick start and feature overview

Related to #5973

Test plan

  • Verify docs render correctly on the docs site
  • Verify all internal links resolve correctly
  • Verify code examples are syntactically correct

🤖 Generated with Claude Code

Open with Devin

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@patelchaitany
patelchaitany requested a review from a team as a code owner March 31, 2026 10:25
devin-ai-integration[bot]
devin-ai-integration Bot reviewed Mar 31, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@patelchaitany
patelchaitany force-pushed the docs/doc-embedder-pr-5973 branch from 1ff66e9 to 79a91f1 Compare March 31, 2026 12:08
@patelchaitany

patelchaitany commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

Hey,@franciscojavierarceo I changed the name of the LogicalLayerFn -> SchemaMapperFn which is more intuitive than previous name Commets. Pls let me know if any changes required.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@patelchaitany
patelchaitany force-pushed the docs/doc-embedder-pr-5973 branch from 79a91f1 to 75fe26e Compare April 1, 2026 08:53
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shuchu
shuchu approved these changes Apr 10, 2026
View reviewed changes

@shuchu shuchu left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@patelchaitany
Add DocEmbedder docs and examples
c11a80e 
Signed-off-by: Chaitany patel <[email protected]>
@patelchaitany
patelchaitany force-pushed the docs/doc-embedder-pr-5973 branch from f215de9 to c11a80e Compare April 14, 2026 05:34
ntkathole
ntkathole approved these changes Apr 14, 2026
View reviewed changes
@ntkathole ntkathole added the ok-to-test label Apr 14, 2026
@ntkathole
ntkathole merged commit 9b185ee into feast-dev:master Apr 14, 2026
37 of 38 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@shuchu shuchu shuchu approved these changes
@ntkathole ntkathole ntkathole approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@patelchaitany @shuchu @ntkathole
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.