GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — fix: Handle numpy.ndarray from Arrow/Athena in Array(String) materialisation by Abhishek8108 · Pull Request #6388 · feast-dev/feast Conversation
Contributor
SummaryCloses #6325 Materialising feature views with Root causes1. Nullable Arrow columns embed 2. The generic list conversion calls Fix
The fix covers all three failure modes from #6325:
Changes
Test plan
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…isation Athena (and other Arrow-backed offline stores) deserialises Array(String) feature columns as numpy.ndarray with object dtype rather than plain Python lists. Two code paths in type_map.py did not handle this: 1. _validate_collection_item_types iterated over the ndarray directly. Nullable Arrow columns can embed None elements, and type(None) is not in the valid_types set for STRING_LIST ([np.str_, str]), causing TypeError. 2. The generic list conversion path in _convert_list_values_to_proto passed the raw ndarray to StringList(val=...). Protobuf rejects non-list inputs with TypeError: bad argument type for built-in operation. Fix: - Coerce ndarray to a plain Python list via .tolist() before type validation, and skip None elements (nullable elements cannot be held in protobuf fixed-type lists and are stripped). - In the generic conversion path, apply the same coercion so protobuf always receives a plain list. Adds four unit tests covering: plain ndarray, ndarray with None elements, empty ndarray, and mixed None/ndarray rows. Fixes feast-dev#6325 Signed-off-by: Abhishek8108 <[email protected]> This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Bug: TypeError / ValueError when materializing Array(String) feature views with Athena offline storeUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |