GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — feat(operator): Auto-create KubeRay RBAC for Feast service account by aravind-n · Pull Request #6411 · feast-dev/feast ConversationWhat this PR does / why we need it:When a This PR makes the operator provision that RBAC automatically:
Which issue(s) this PR fixes:Fixes #6408 Checks
Testing Strategy
MiscNew ginkgo suite at
The operator's full suite (
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsWhen the batch-engine ConfigMap selects the Ray engine in KubeRay mode
(type: ray.engine, use_kuberay: true), the Feast service pod uses the
CodeFlare SDK to discover RayCluster resources and read mTLS Secrets.
Previously the Feast SA had no permissions on either, so the SDK calls
returned 403 and users had to apply the Role + RoleBinding by hand
before every materialization run.
This change makes the operator provision them automatically:
- New services/ray_rbac.go reads the batch-engine ConfigMap once per
reconcile and, when KubeRay is selected, CreateOrUpdates a
namespace-scoped Role + RoleBinding named feast-<crName>-kuberay
granting the Feast SA:
ray.io/rayclusters: get, list, watch
core/secrets: get, list, watch, create, update, delete
- Both resources are owner-referenced to the FeatureStore so they
GC with the CR. When use_kuberay flips back to false (or the
batchEngine block is removed), they are deleted on the next
reconcile.
- The operator's own kubebuilder RBAC markers are widened to match
so it can hand those verbs to the Feast SA (k8s RBAC escalation
rules require the granter to hold the granted verbs). config/rbac
and dist/install.yaml are regenerated accordingly.
- New ginkgo suite covers create-on-enable, delete-on-disable, and
no-op when batchEngine is absent.
- 06-batch-and-jobs.md documents the new auto-RBAC behavior so users
know manual setup is no longer required.
Fixes feast-dev#6408
Signed-off-by: Aravind Nidadavolu <[email protected]>
aravind-n
force-pushed
the
feat/operator-auto-rbac-kuberay
branch
from
08a3fc9 to
2f10a08
Compare
This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Feast Operator should auto-create RBAC for Feast service account to access KubeRay clusterUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |