GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Add async_supported property to RedisOnlineStore by ntkathole · Pull Request #6446 · feast-dev/feast

Conversation

@ntkathole

@ntkathole ntkathole commented May 28, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:

RedisOnlineStore implements full async support (online_read_async,
online_write_batch_async, _get_client_async using redis.asyncio), but
does not override the async_supported property from the base OnlineStore
class. The default returns SupportedAsyncMethods(read=False, write=False),
so the feature server never uses the async path — falling back to
run_in_threadpool(sync) on every request.

Which issue(s) this PR fixes:

Fixes #6437

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ntkathole ntkathole self-assigned this May 28, 2026
@ntkathole
ntkathole requested a review from a team as a code owner May 28, 2026 08:27
@ntkathole ntkathole added the ok-to-test label May 28, 2026
franciscojavierarceo
franciscojavierarceo approved these changes May 30, 2026
View reviewed changes
@ntkathole
fix: Add async_supported property to RedisOnlineStore
c0728d8
Signed-off-by: ntkathole <[email protected]>
@ntkathole
ntkathole force-pushed the fix_6437 branch from 4d51df8 to c0728d8 Compare May 30, 2026 15:59
@ntkathole
ntkathole merged commit 9b088fe into feast-dev:master May 30, 2026
17 of 25 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@chandlerok chandlerok mentioned this pull request Sep 25, 2026
feat: Add optional GLIDE client for Redis online reads #6870
Merged
5 of 7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ntkathole ntkathole

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RedisOnlineStore missing async_supported property - server never uses async Redis path

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ntkathole @franciscojavierarceo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.