GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: Add regression tests for protobuf >= 7.34.0 compatibility (#6435) by Jwrede · Pull Request #6450 · feast-dev/feast

Conversation

@Jwrede

@Jwrede Jwrede commented May 29, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Adds regression tests to guard against reintroduction of the float_precision kwarg usage that was removed in PR #6015. The MessageToDict(float_precision=...) call caused feature_server.py to crash on protobuf >= 7.34.0 (see #6435). While the fix landed in #6015, there were no tests preventing reintroduction.

Two tests added:

  • test_no_message_to_dict_dependency -- patches MessageToDict to raise if called, proving convert_response_to_dict is independent of it
  • test_double_precision_without_float_precision_kwarg -- verifies doubles (including edge cases like very small and very large values) round-trip correctly without the removed parameter

Which issue(s) this PR fixes:

Fixes #6435

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Jwrede
Jwrede requested a review from a team as a code owner May 29, 2026 05:52
@Jwrede Jwrede changed the title test: add regression tests for protobuf >= 7.34.0 compatibility (#6435) test: Add regression tests for protobuf >= 7.34.0 compatibility (#6435) May 29, 2026
@ntkathole ntkathole added the ok-to-test label May 29, 2026
ntkathole
ntkathole approved these changes May 29, 2026
View reviewed changes
@Jwrede @ntkathole
test: add regression tests for protobuf >= 7.34.0 compatibility (feas…
02f200b 
…t-dev#6435)

PR feast-dev#6015 replaced MessageToDict with a custom dict builder in
feature_server.py, which incidentally fixed the crash caused by the
removed float_precision kwarg in protobuf >= 7.34.0.

Add explicit regression tests to prevent reintroduction:
- Verify convert_response_to_dict never calls MessageToDict
- Verify double precision round-trips without float_precision kwarg

Fixes feast-dev#6435

Assisted-by: Claude Opus 4.6
Signed-off-by: Jonathan Wrede <[email protected]>
@ntkathole
ntkathole force-pushed the fix/protobuf-float-precision branch from fec2a08 to 02f200b Compare May 29, 2026 08:15
@ntkathole
ntkathole merged commit a6a2a81 into feast-dev:master May 29, 2026
21 of 25 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@xKomil xKomil mentioned this pull request Aug 18, 2026
odh-feature-server-rhel9 (feast 0.62.0): /get-online-features returns 500 due to removed protobuf float_precision kwarg (fixed upstream in feast-dev/feast#6015, needs feast>=0.64.0) opendatahub-io/feast#193
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntkathole ntkathole ntkathole approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature_server.py crashes with TypeError: MessageToDict() got an unexpected keyword argument 'float_precision' on protobuf >= 7.34.0

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Jwrede @ntkathole
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.