GeezerVison is showing github.com — fix: source-first UDF rehydrate, Postgres empty-cols SELECT *, online allow_cache=False by aniketpalu · Pull Request #6620 · feast-dev/feast
Conversation
aniketpalu
commented
Jul 20, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Summary
- F1/F2: Prefer registry
body_text over dill.loads(body) when restoring UDFs (udf_rehydrate.resolve_udf), including Spark transform execute and Pandas/Python/Ray from_proto. Strip leading decorators (e.g. @on_demand_feature_view) before exec so ODFV source rehydrates cleanly.
- F3: Postgres offline store treats empty
feature_name_columns as “all columns” (SELECT * / DISTINCT ON … a.*), matching BatchFeatureView python/pandas mode and Ray semantics.
- F5a: Online request path always reads FVs with
allow_cache=False so FeatureViewState gates see AVAILABLE_ONLINE after materialize (no stale MATERIALIZING/GENERATED 500s).
Out of scope (separate PR)
Test plan
- Unit:
test_udf_rehydrate.py (source preference, decorator strip, dill fallback)
- Unit: Postgres empty
feature_cols → SELECT * / star path
- E2E (optional): SparkApplication UDF materialize + ODFV online on mixed Python images
Made with Cursor
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…istry reads
Rehydrate BatchFeatureView/ODFV callables from body_text (strip leading
decorators) before dill.loads to avoid Spark driver exit 139 and
cross-Python serve failures. Treat empty Postgres feature_name_columns as
SELECT *. Disable registry cache on the online request path so FeatureView
state gates see AVAILABLE_ONLINE immediately after materialize.
Co-authored-by: Cursor <[email protected]>
|
|
# dill.source.getsource() output. They are not needed to recover the callable and
|
|
|
# usually reference names unavailable at rehydrate time.
|
|
|
_DECORATOR_BLOCK = re.compile(
|
|
|
r"^(?:\s*@[\s\S]*?\n)+(?=\s*(?:async\s+)?def\s+)",
|
|
⚠️ Please install the  to ensure uploads and comments are reliably processed by Codecov.
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.94%. Comparing base (294efad) to head (35dca23).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #6620 +/- ##
==========================================
- Coverage 45.94% 45.94% -0.01%
==========================================
Files 412 412
Lines 48864 48853 -11
Branches 6913 6913
==========================================
- Hits 22452 22444 -8
+ Misses 24859 24856 -3
Partials 1553 1553 *This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Harness.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 294efad...35dca23. Read the comment docs.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
