GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||
GeezerVison is showing github.com — fix: Report single-feature-view spark_application materialization success by adarshsm · Pull Request #6700 · feast-dev/feast Conversation
Contributor
What this doesFixes #6673. Every single-feature-view materialization on the even though the Spark driver already materialized the features and updated the registry. Automation calling Root cause
try: self._wait_for_completion(job) return self._build_per_fv_jobs(registry, tasks, job_id, job) finally: self._cleanup(job_id) # deletes the CR For a single feature view, if len(tasks) <= 1: return [job for _ in tasks]
FixResolve the per-FV outcome from registry state for every task count — exactly what the multi-FV path already does. The driver pod sets each materialized FV to
The now-unused TestsThe existing single-task test asserted the buggy behavior (return the live job, skip the registry). Rewrote it to require resolution from registry state with no CR query, and added a single-failed-FV case. All Verified the before/after on the real classes: a live job re-checked after CR deletion returns
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #6700 +/- ## ========================================== - Coverage 46.80% 46.80% -0.01% ========================================== Files 415 415 Lines 50397 50395 -2 Branches 7215 7214 -1 ========================================== - Hits 23589 23588 -1 Misses 25155 25155 + Partials 1653 1652 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The single-task path now resolves the outcome from registry state before the SparkApplication CR is deleted, and the tests cover both successful and failed single-feature-view materializations without a post-cleanup Kubernetes lookup. I found no blocking issue in the remote diff.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @adarshsm for raising the fix. Please fix the CI. LGTM |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…cess `SparkApplicationComputeEngine.materialize()` deletes the SparkApplication CR in its `finally` immediately after `_build_per_fv_jobs()` returns. For a single feature view, `_build_per_fv_jobs()` short-circuited and returned the live polling job. `FeatureStore._submit_and_process_materialization_jobs()` then re-checks `job.status()`, which re-queries the just-deleted CR, gets a 404, and raises `SparkApplication feast-sa-<id> not found` — for a materialization that actually succeeded and already updated the registry. Automation calling `feast materialize` or `/materialize` sees a failure and may retry completed work. The bug is deterministic for exactly one feature view. Resolve the per-FV outcome from registry state for every task count, exactly as the multi-FV path already does: a materialized FV (`AVAILABLE_ONLINE`) becomes a `CompletedMaterializationJob`, which reports SUCCEEDED without any Kubernetes call and is therefore safe after cleanup. The now-unused `job` parameter is dropped. Genuine failures still surface as ERROR (the FV is not `AVAILABLE_ONLINE`), and the Spark driver's error detail is already logged by `_wait_for_completion`. Updated the single-task unit test, which previously asserted the buggy behavior (return the live job, skip the registry), to require resolution from registry state with no CR query, and added a single-failed-FV case. Fixes feast-dev#6673 Signed-off-by: adarshsm <[email protected]>
f65040a to
abf7dc5
Compare
|
@aniketpalu I rebased onto current master ( The failure is always in
This PR only touches Looks like a flaky dependency resolution in the CI install step rather than anything a PR can fix. Happy to re-run once master is green if you would rather see a clean board first. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
spark_application engine reports successful single-feature-view materializations as failure
There was an error while loading. Please reload this page.