GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Remove inert subjectaccessreviews and reorganize RBAC rules by ntkathole · Pull Request #6736 · feast-dev/feast

Conversation

@ntkathole

@ntkathole ntkathole commented Aug 13, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Summary

Remove the unused subjectaccessreviews from the operator ClusterRole and reorganize the RBAC rules for clusterrolebindings and clusterroles to follow the principle of least privilege.

Changes

  • Remove subjectaccessreviews from both role.yaml and authz.go
  • Separate clusterrolebindings with its own verb set
  • Split clusterroles into general create and named resource management

Test Plan

  • Unit tests passing

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ntkathole
ntkathole requested a review from a team as a code owner August 13, 2026 15:11
@ntkathole
ntkathole force-pushed the fix/remove-subjectaccessreviews branch from f413d82 to d29cb50 Compare August 13, 2026 15:17
@codecov-commenter

codecov-commenter commented Aug 13, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.82%. Comparing base (89240fa) to head (7577f6b).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6736   +/-   ##
=======================================
  Coverage   46.82%   46.82%           
=======================================
  Files         415      415           
  Lines       50406    50406           
  Branches     7215     7215           
=======================================
  Hits        23601    23601           
  Misses      25155    25155           
  Partials     1650     1650
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 48.14% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89240fa...7577f6b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ntkathole
ntkathole force-pushed the fix/remove-subjectaccessreviews branch 2 times, most recently from 9054385 to b93fe1b Compare August 13, 2026 16:16
@ntkathole ntkathole added the ok-to-test label Aug 13, 2026
@ntkathole
fix: Remove inert subjectaccessreviews and reorganize RBAC rules
7577f6b 
Signed-off-by: ntkathole <[email protected]>
@ntkathole
ntkathole force-pushed the fix/remove-subjectaccessreviews branch from b93fe1b to 7577f6b Compare August 15, 2026 15:42
haoxu0
haoxu0 approved these changes Aug 16, 2026
View reviewed changes
haoxu0
haoxu0 approved these changes Aug 16, 2026
View reviewed changes

@haoxu0 haoxu0 left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RBAC split matches the controller's actual CreateOrUpdate and cleanup operations, and removing the inert subjectaccessreviews rules is correct. No blocking findings from my review.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ntkathole
ntkathole merged commit f771ea4 into feast-dev:master Aug 16, 2026
24 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@patelchaitany patelchaitany mentioned this pull request Oct 27, 2026
fix: add watch verb on clusterroles and clusterrolebindings for feast-operator #7062
Merged
4 of 7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haoxu0 haoxu0 haoxu0 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ntkathole @codecov-commenter @haoxu0
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.