GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: Remove flaky key encoding timing assertion by larrysingleton007 · Pull Request #6746 · feast-dev/feast

Conversation

@larrysingleton007

@larrysingleton007 larrysingleton007 commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

What this PR does

Removes test_performance_bounds_single_entity from the parallel unit suite. The test measures 1,000 operations against an absolute 0.2-second wall-clock limit, which remains sensitive to shared-runner contention after two earlier threshold increases.

Correctness remains covered by test_single_entity_fast_path. Performance remains covered by sdk/python/tests/benchmarks/test_key_encoding_benchmarks.py, where pytest-benchmark reports calibrated results instead of enforcing an absolute wall-clock assertion in the unit suite.

Testing

  • Key encoding unit module: 14 passed
  • Key encoding benchmarks: 2 passed (about 916k serialization and 714k deserialization operations per second locally)
  • Python unit suite: 2,536 passed, 20 skipped
  • Ruff and pre-commit checks passed

Review requests

  • kind/bug
  • ok-to-test

Fixes #6745

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@larrysingleton007
larrysingleton007 requested a review from a team as a code owner August 16, 2026 13:44
@larrysingleton007 larrysingleton007 mentioned this pull request Aug 16, 2026
Key encoding unit test flakes on wall-clock performance bound #6745
Closed
@codecov-commenter

codecov-commenter commented Aug 16, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.96%. Comparing base (602d752) to head (bf74d29).
⚠️ Report is 5 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6746      +/-   ##
==========================================
+ Coverage   46.91%   46.96%   +0.05%     
==========================================
  Files         416      416              
  Lines       50545    50606      +61     
  Branches     7252     7262      +10     
==========================================
+ Hits        23714    23768      +54     
- Misses      25157    25159       +2     
- Partials     1674     1679       +5
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 48.30% <ø> (+0.05%) ⬆️
see 6 files with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 602d752...bf74d29. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ntkathole ntkathole added the ok-to-test label Aug 18, 2026
ntkathole
ntkathole approved these changes Aug 18, 2026
View reviewed changes
@larrysingleton007 @ntkathole
test: Remove flaky key encoding timing assertion
bf74d29 
Fixes feast-dev#6745

Signed-off-by: Larry Singleton <[email protected]>
@ntkathole
ntkathole force-pushed the fix/issue-6745-key-encoding-wall-clock-flake branch from 10d4a9f to bf74d29 Compare August 18, 2026 04:15
@ntkathole
ntkathole merged commit aa7b685 into feast-dev:master Aug 18, 2026
18 of 22 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@larrysingleton007
larrysingleton007 deleted the fix/issue-6745-key-encoding-wall-clock-flake branch September 14, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntkathole ntkathole ntkathole approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Key encoding unit test flakes on wall-clock performance bound

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@larrysingleton007 @codecov-commenter @ntkathole
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.