GeezerVison is showing github.com — ci: Stabilize FIPS import test and repair CPU wheel hashes by franciscojavierarceo · Pull Request #6835 · feast-dev/feast
Conversation
What this PR does / why we need it:
The FIPS import-order test exceeded its 60-second subprocess deadline in the Python 3.11/macOS unit-test job for #6188. Give the fresh Feast import 180 seconds to complete under CI load while preserving the FIPS and import-order assertions.
Schedule a faulthandler stack dump after 120 seconds and include captured stdout/stderr in timeout failures. This provides evidence of where a future slow or stalled import is spending time. Handle missing output and decode captured bytes with replacement for invalid characters.
Linux CI also fails before tests because --torch-backend cpu selects CPU wheels whose hashes are absent from the existing locks. Add the published CPU wheel hashes for the pinned torch and torchvision versions to all three CI lockfiles, retaining the existing versions and PyPI hashes. These hashes were generated with uv pip compile --no-deps --torch-backend cpu --universal --generate-hashes for the existing pins. The broader lock-generation changes are tracked in #6825.
Which issue(s) this PR fixes:
Mitigates the timeout observed in this CI job. The original log does not identify the stalled import, so the longer deadline is a mitigation rather than proof of the underlying cause.
Checks
- I've made sure CI is passing: all 20 active checks passed on
cda845de7, including all five Python unit-test configurations, both lint jobs, and smoke tests. Five unrelated checks were skipped.
- My commits are signed off (
git commit -s)
- My PR title follows conventional commits format
Testing Strategy
- Unit tests: all 10 tests in
sdk/python/tests/unit/test_offline_server.py passed locally on macOS with Python 3.12.
- Manual tests: forced a real subprocess to stall with shortened diagnostic/deadline timers; verified the failure includes stdout and the faulthandler stack dump. Also verified a timeout without captured output.
- Dependency validation: reproduced the original torchvision hash mismatch with CI's uv 0.12.13, then successfully installed both CPU wheels from the updated lock entries targeting Linux x86_64 for Python 3.10, 3.11, and 3.12. Verified that package versions, original hashes, and all non-PyTorch entries remain unchanged.
- Integration tests
- Testing is not required for this change
Ruff lint and formatting checks passed for the changed file. Scoped mypy (--follow-imports=silent tests/unit/test_offline_server.py) also passed.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
chatgpt-codex-connector[bot] reacted with thumbs up emoji
Codex Review Summary
This comment shows the latest Codex review activity on this pull request.
| Review |
Status |
Commit |
Review trigger |
| 📝 Code Review |
✅ Completed 2026-09-14T13:51:18.127502Z |
05a27c0 |
PR opened |
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review" or "@codex security review".
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.10%. Comparing base (81e1546) to head (cda845d).
⚠️ Report is 2 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@ Coverage Diff @@
## master #6835 +/- ##
==========================================
+ Coverage 47.08% 47.10% +0.01%
==========================================
Files 419 419
Lines 51877 51879 +2
Branches 7525 7525
==========================================
+ Hits 24428 24436 +8
+ Misses 25700 25693 -7
- Partials 1749 1750 +1
Continue to review full report in Codecov by Harness.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7a8928...cda845d. Read the comment docs.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
franciscojavierarceo
changed the title
test: Reduce FIPS import timeout flakes and capture diagnostics
ci: Stabilize FIPS import test and repair CPU wheel hashes
Sep 14, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|