GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ci: Stabilize FIPS import test and repair CPU wheel hashes by franciscojavierarceo · Pull Request #6835 · feast-dev/feast

Conversation

@franciscojavierarceo

@franciscojavierarceo franciscojavierarceo commented Sep 14, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

What this PR does / why we need it:

The FIPS import-order test exceeded its 60-second subprocess deadline in the Python 3.11/macOS unit-test job for #6188. Give the fresh Feast import 180 seconds to complete under CI load while preserving the FIPS and import-order assertions.

Schedule a faulthandler stack dump after 120 seconds and include captured stdout/stderr in timeout failures. This provides evidence of where a future slow or stalled import is spending time. Handle missing output and decode captured bytes with replacement for invalid characters.

Linux CI also fails before tests because --torch-backend cpu selects CPU wheels whose hashes are absent from the existing locks. Add the published CPU wheel hashes for the pinned torch and torchvision versions to all three CI lockfiles, retaining the existing versions and PyPI hashes. These hashes were generated with uv pip compile --no-deps --torch-backend cpu --universal --generate-hashes for the existing pins. The broader lock-generation changes are tracked in #6825.

Which issue(s) this PR fixes:

Mitigates the timeout observed in this CI job. The original log does not identify the stalled import, so the longer deadline is a mitigation rather than proof of the underlying cause.

Checks

  • I've made sure CI is passing: all 20 active checks passed on cda845de7, including all five Python unit-test configurations, both lint jobs, and smoke tests. Five unrelated checks were skipped.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests: all 10 tests in sdk/python/tests/unit/test_offline_server.py passed locally on macOS with Python 3.12.
  • Manual tests: forced a real subprocess to stall with shortened diagnostic/deadline timers; verified the failure includes stdout and the faulthandler stack dump. Also verified a timeout without captured output.
  • Dependency validation: reproduced the original torchvision hash mismatch with CI's uv 0.12.13, then successfully installed both CPU wheels from the updated lock entries targeting Linux x86_64 for Python 3.10, 3.11, and 3.12. Verified that package versions, original hashes, and all non-PyTorch entries remain unchanged.
  • Integration tests
  • Testing is not required for this change

Ruff lint and formatting checks passed for the changed file. Scoped mypy (--follow-imports=silent tests/unit/test_offline_server.py) also passed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@franciscojavierarceo
test: Reduce FIPS import timeout flakes and capture diagnostics
05a27c0
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
franciscojavierarceo requested a review from a team as a code owner September 14, 2026 13:47
@franciscojavierarceo franciscojavierarceo added the kind/housekeeping label Sep 14, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-14T13:51:18.127502Z 05a27c0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@codecov-commenter

codecov-commenter commented Sep 14, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.10%. Comparing base (81e1546) to head (cda845d).
⚠️ Report is 2 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6835      +/-   ##
==========================================
+ Coverage   47.08%   47.10%   +0.01%     
==========================================
  Files         419      419              
  Lines       51877    51879       +2     
  Branches     7525     7525              
==========================================
+ Hits        24428    24436       +8     
+ Misses      25700    25693       -7     
- Partials     1749     1750       +1     
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 48.41% <ø> (+0.01%) ⬆️
see 3 files with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7a8928...cda845d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@franciscojavierarceo
ci: Add missing CPU wheel hashes to CI requirements
cda845d
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo franciscojavierarceo changed the title test: Reduce FIPS import timeout flakes and capture diagnostics ci: Stabilize FIPS import test and repair CPU wheel hashes Sep 14, 2026
@franciscojavierarceo
franciscojavierarceo merged commit 9f7b503 into master Sep 14, 2026
26 of 27 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@DKilkenny DKilkenny mentioned this pull request Sep 14, 2026
feat: Batch Postgres online reads across feature views #6832
Merged
6 of 7 tasks
@jingqian-liu jingqian-liu mentioned this pull request Sep 14, 2026
feat: Bucket feature count labels in latency metrics #6811
Merged
@patelchaitany patelchaitany mentioned this pull request Sep 15, 2026
Merge upstream/master into master (resolve conflicts) opendatahub-io/feast#216
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

kind/housekeeping

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@franciscojavierarceo @codecov-commenter
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.