GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(operator): Set grpc appProtocol on the offline Service port by patelchaitany · Pull Request #6869 · feast-dev/feast

Conversation

@patelchaitany

@patelchaitany patelchaitany commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Fixes #6866

The offline server talks gRPC (Arrow Flight), but the operator was creating its Service with a port named http and no appProtocol. So Istio treats it as HTTP/1.1 and gRPC calls go sideways.

#6367 already fixed this for the registry. This just extends the same check in getServiceAppProtocol() to cover the offline Service too, so it now gets appProtocol: grpc.

Also updated the old test that expected nil for offline, and added one that renders the actual offline Service and checks the port.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@patelchaitany
fix(operator): Set grpc appProtocol on the offline Service port
d645174 
The offline server is an Arrow Flight (gRPC) server, but its Service port
was rendered with name "http" and no appProtocol. Protocol-aware meshes
such as Istio then fall back to HTTP/1.1 and break gRPC traffic.

Extend getServiceAppProtocol() to return "grpc" for OfflineFeastType,
following the same pattern used for the registry gRPC Service.

Signed-off-by: Chaitany Patel <[email protected]>
@patelchaitany
patelchaitany requested a review from a team as a code owner September 25, 2026 08:41
@codecov-commenter

codecov-commenter commented Sep 25, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.66%. Comparing base (d4e9619) to head (d645174).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6869   +/-   ##
=======================================
  Coverage   47.66%   47.66%           
=======================================
  Files         422      422           
  Lines       52389    52389           
  Branches     7604     7604           
=======================================
  Hits        24971    24971           
  Misses      25625    25625           
  Partials     1793     1793
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 49.00% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4e9619...d645174. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ntkathole ntkathole added the ok-to-test label Sep 25, 2026
ntkathole
ntkathole approved these changes Sep 26, 2026
View reviewed changes
@ntkathole
ntkathole merged commit f9dcfb5 into feast-dev:master Sep 26, 2026
38 of 39 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntkathole ntkathole ntkathole approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Offline Service is never given appProtocol: grpc (registry fixed by #6367)

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@patelchaitany @codecov-commenter @ntkathole
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.