GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: Run MCP audit handler coroutines with asyncio.run by alan-gauthier-jt · Pull Request #6890 · feast-dev/feast

Conversation

@alan-gauthier-jt

@alan-gauthier-jt alan-gauthier-jt commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

tests/unit/audit/test_mcp_audit_handler.py fails on master depending on test ordering (e.g. on PR #6789, all Python versions): RuntimeError: There is no current event loop in thread 'MainThread'.

  • Its _run helper uses asyncio.get_event_loop(), which raises once a previous test on the same xdist worker has called asyncio.run() (which unsets the loop), as test_precomputed_feature_vectors.py now does since ce37029.
  • Switch the helper to asyncio.run(coro) so the tests no longer depend on a leftover event loop.

Reproduce on master: pytest tests/unit/test_precomputed_feature_vectors.py tests/unit/audit/test_mcp_audit_handler.py

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@alan-gauthier-jt
test: Run MCP audit handler coroutines with asyncio.run
28b67f9
Signed-off-by: Alan Gauthier <[email protected]>
@codecov-commenter

codecov-commenter commented Sep 29, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.84%. Comparing base (a87c070) to head (28b67f9).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6890      +/-   ##
==========================================
- Coverage   47.84%   47.84%   -0.01%     
==========================================
  Files         422      422              
  Lines       52727    52727              
  Branches     7662     7662              
==========================================
- Hits        25226    25225       -1     
  Misses      25680    25680              
- Partials     1821     1822       +1     
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 49.18% <ø> (-0.01%) ⬇️
see 1 file with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a87c070...28b67f9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@alan-gauthier-jt
alan-gauthier-jt marked this pull request as ready for review September 29, 2026 08:50
@alan-gauthier-jt
alan-gauthier-jt requested a review from a team as a code owner September 29, 2026 08:50
@alan-gauthier-jt alan-gauthier-jt mentioned this pull request Sep 29, 2026
fix: Allow serving features while a feature view is MATERIALIZING #6789
Merged
@ntkathole ntkathole added the ok-to-test label Sep 29, 2026
ntkathole
ntkathole approved these changes Sep 29, 2026
View reviewed changes
@ntkathole
ntkathole merged commit 5791474 into feast-dev:master Sep 29, 2026
36 of 37 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntkathole ntkathole ntkathole approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@alan-gauthier-jt @codecov-commenter @ntkathole
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.