GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||
GeezerVison is showing github.com — fix: Keep tiling, offline and stream engine settings when copying a StreamFeatureView by Rodrigo-Palma · Pull Request #6924 · feast-dev/feast Conversation
Contributor
What this PR does / why we need it:
sfv = StreamFeatureView(..., offline=True, enable_tiling=True, tiling_hop_size=timedelta(minutes=1), stream_engine={"spark.sql.shuffle.partitions": "4"}) copy.copy(sfv).enable_tiling # False sfv == copy.copy(sfv) # False (offline differs) The registry also uses Which issue(s) this PR fixes:N/A Checks
Testing Strategy
Extended
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #6924 +/- ## ======================================= Coverage 48.71% 48.71% ======================================= Files 427 427 Lines 53934 53934 Branches 7865 7865 ======================================= Hits 26272 26272 Misses 25789 25789 Partials 1873 1873
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
a8bcd00 to
0f04038
Compare
|
@Rodrigo-Palma Please fix the checks failing. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@jyejare Both failures come from |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…treamFeatureView Signed-off-by: Rodrigo-Palma <[email protected]>
0f04038 to
9625bb4
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.