GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||
GeezerVison is showing github.com — test: Cover the universal torch split in add_cpu_torch_hashes by haoxu0 · Pull Request #6980 · feast-dev/feast Conversation
Collaborator
#6906 taught That behaviour is still untested, and the gap is the reason the target could ship unable to run at all. Both existing tests pass a bare What is addedTwo tests, no production code:
Both assert idempotency. The second also asserts the Verification
I had opened #6959 proposing the same fix before #6906 merged; the approach there was identical (
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #6980 +/- ## ======================================= Coverage 49.92% 49.92% ======================================= Files 443 443 Lines 55511 55511 Branches 8096 8096 ======================================= Hits 27714 27714 Misses 25874 25874 Partials 1923 1923
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
feast-dev#6906 taught `add_cpu_hashes` to leave an existing `+cpu` pin alone, which is what `make lock-python-dependencies-all` needed to get past ValueError: Missing CPU hashes for torch==2.14.1+cpu That behaviour is still untested. Both existing tests pass a bare `torch==2.13.0` as the requirements being patched and put `+cpu` only in the lookup table, so neither exercises a `+cpu` entry on the side that gets rewritten -- which is why the lock target could ship unable to run. Two tests are added for the shape a real `--universal --torch-backend cpu` resolve emits: torch==2.13.0 ; sys_platform == 'darwin' torch==2.13.0+cpu ; sys_platform != 'darwin' one for a single package and one for the torch and torchvision pair the committed locks actually contain. Both assert idempotency, and the second asserts the `+cpu` line is left exactly as the resolver wrote it rather than merged into, so a future change cannot widen the set of artifacts that pin accepts without failing here. No production code is touched; these pass against feast-dev#6906's fix as merged. Signed-off-by: hao-xu5 <[email protected]>
65840a8 to
bb1dc75
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.