GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — feat: Add zoom, scroll and hover values to the monitoring charts by patelchaitany · Pull Request #7090 · feast-dev/feast Conversation
Contributor
What this PR does / why we need it:The data quality monitoring charts on the feature detail page are hand-drawn SVG with no interaction. You cannot read exact values, zoom into a crowded range, or look at small bars. The time series also draws every row the API returns as one line, so different window lengths (daily, weekly, monthly, quarterly) and the baseline are joined together. That creates spikes and drops that are not in the data. This PR is UI only. The API and the stored metrics are unchanged. Time series
Distribution (numeric histogram)
The zoom, scroll, hover and tooltip code is shared in ScreenshotsDemo data: one feature view, hourly data for 20 drivers from 2026-07-01 to 2026-10-29, with daily, weekly and monthly metrics plus the baseline. Time series, All time
Time series, Last 30 days
Time series: zoom, hover and scroll
Distribution
Which issue(s) this PR fixes:Part of #7054: fixes case 3 (the time series mixes window lengths) and keeps the baseline off the time-series line. Cases 1, 2 and 4 are not changed here. #7056 and #7057 also edit Checks
Testing Strategy
Unit test: Manual: built the UI and ran Misc
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #7090 +/- ## ========================================== + Coverage 51.82% 51.88% +0.06% ========================================== Files 458 458 Lines 57749 57757 +8 Branches 8488 8490 +2 ========================================== + Hits 29930 29970 +40 + Misses 25792 25755 -37 - Partials 2027 2032 +5
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
ee797ac to
ed6b3fd
Compare
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@patelchaitany please update the PR since it is out-of-date. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
1fca127 to
c27f52b
Compare
|
@patelchaitany need to resolve conflicts |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
c27f52b to
4e1d48b
Compare
4e1d48b to
a5d20bf
Compare
a5d20bf to
bf2819b
Compare
bf2819b to
d674dd5
Compare
The DQM time series and distribution charts were static SVG with no way to read exact values, and the time series joined every window length into one line. - Time series: plot one window length at a time (the one picked in View, or daily when View is the baseline) and keep the baseline row off the line. - Time series and distribution: hover shows exact values, drag to zoom, zoom in/out/reset buttons, and sideways scrolling through all the data while zoomed in. - Distribution: leave room above the plot so the top axis label is not cut off. Signed-off-by: Chaitany Patel <[email protected]>
d674dd5 to
ad94f18
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.