GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||
GeezerVison is showing github.com — fix: Keep description, tags and nested types of ODFV schema fields by Revinand · Pull Request #7091 · feast-dev/feast Conversation
Contributor
What this PR does / why we need it:An on-demand feature view cannot have schema fields with a
With only that change,
To reproduce, add Which issue(s) this PR fixes:Fixes #3617. The stale bot closed it in 2025 without a fix. It reports the first half; the registry round-trip has no issue. Checks
Testing Strategy
Misc
ODFVs that are already registered with Struct or nested outputs now load with their real inner types instead of
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsSigned-off-by: Revinand <[email protected]>
|
There was an error while loading. Please reload this page.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #7091 +/- ## ========================================== + Coverage 50.97% 50.99% +0.01% ========================================== Files 455 455 Lines 56994 56994 Branches 8321 8321 ========================================== + Hits 29055 29062 +7 + Misses 25954 25946 -8 - Partials 1985 1986 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Defining anon_demand_feature_view fails if fields have descriptions
There was an error while loading. Please reload this page.