GeezerVison is showing github.com — fix: Filter GitBook default site space client-side when publishing versioned docs by ntkathole · Pull Request #7141 · feast-dev/feast
Conversation
ntkathole
commented
Nov 12, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
What
publish_versioned_docs.py (added in #6763) aborts when publishing a versioned docs space, failing with:
RuntimeError: expected one default GitBook site space, found 54
Why
The script lists site spaces with GET .../site-spaces?default=true and trusts GitBook to return only the single default space. In practice GitBook ignores the default query filter and returns every linked site space, so the script sees 54 "defaults" and bails out in _duplicate_default_space before importing the release branch. Nothing downstream (branch import, default switch, publish) ever ran, so no GitBook state was changed — the job just failed.
This was confirmed against the live Feast site with a read-only inspection: 54 total site spaces, exactly 1 with default == true, no sections (the /sections endpoint 404s), and ?default=true returning all 54 — i.e. the filter is not applied server-side.
Fix
_list_site_spaces() now paginates (next.page) and, when a default is requested, filters on the default flag client-side, so the single default space is identified regardless of whether GitBook honors the query filter.
- The "more than one default" error now explains the sectioned-site case (each section has its own default space) and that it is unsupported, pointing at the manual process, instead of the bare count.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
GitBook's site-spaces list endpoint ignores the `?default=true` query filter and returns every linked site space, so publish_versioned_docs counted 54 "default" spaces and aborted before importing the release branch.
Paginate the site-spaces listing and filter on the `default` flag client-side so the single default space is identified reliably. Also clarify the multi-default error to explain the (unsupported) sectioned-site case.
Signed-off-by: ntkathole <[email protected]>
|
⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.29%. Comparing base (e81e69d) to head (255cd53).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@ Coverage Diff @@
## master #7141 +/- ##
=======================================
Coverage 52.29% 52.29%
=======================================
Files 459 459
Lines 58090 58090
Branches 8560 8560
=======================================
Hits 30381 30381
Misses 25629 25629
Partials 2080 2080
Continue to review full report in Codecov by Harness.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e81e69d...255cd53. Read the comment docs.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This branch has not been deployed
No deployments
Reviewers
1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.