Description

ethan-xd

opened on Sep 3, 2019

Issue body actions

Reproduction
Chat message "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA". That's it.

Doing this too many times crashes the server, but usually just times you out. This doesn't happen server side however, so this can lead to some quirky side effects.

According to my buddy Lolt every time this happens one core crashes. When the server runs out of cores, the entire server crashes. Sending the chat message then reconnecting on a 6 core server crashed on the 6th attempt.

Activity

1. caelunshun

   added

   bugSomething isn't workingSomething isn't working

   on Sep 4, 2019
2. caelunshun

   added this to the 0.5 milestone on Sep 4, 2019
3. caelunshun commented on Sep 4, 2019

   

   caelunshun

   on Sep 4, 2019

   Member

   More actions

   Seems like the cutoff is at any message of length 253 characters or more. I suspect this is an issue with handling of compressed packets received from the client.
4. caelunshun commented on Sep 4, 2019

   

   caelunshun

   on Sep 4, 2019

   Member

   More actions

   Confirmed that this does not occur when compression is disabled (compression_threshold set to -1 in config).

   Edit: This will be fixed by #42 once it is complete. In the meantime, I will push a hotfix.
5. caelunshun

   closed this as completedin c7488c8on Sep 4, 2019
6. caelunshun commented on Sep 4, 2019

   

   caelunshun

   on Sep 4, 2019

   Member

   More actions

   Thanks for reporting!

   Reacted by Ethan
7. ethan-xd commented on Sep 4, 2019

   

   ethan-xd

   on Sep 4, 2019

   Author

   More actions

   No worries!

   A bit off topic, would you like survival related bug reports (not the usual I break blocks and get nothing) or would you rather wait until an actual release?
8. caelunshun commented on Sep 4, 2019

   

   caelunshun

   on Sep 4, 2019

   Member

   More actions

   No worries!

   A bit off topic, would you like survival related bug reports (not the usual I break blocks and get nothing) or would you rather wait until an actual release?

   Nothing in survival mode is really implemented, but you can reply to #40 with anything you find.

Issue actions