GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Bad client performance · Issue #451 · feather-rs/feather

Bad client performance #451

New issue
Copy link
New issue
Copy link
Open
Open
Bad client performance#451
Copy link

Description

@koskja
koskja
opened on Aug 20, 2021
Issue body actions

Description

The minecraft client experiences awful fps drops when loading new chunks. This is especially noticeable when spawning for the first time and when loading large amounts of blocks. This doesn't happen on vanilla servers.

Reproduction Steps

  1. Start the server
  2. Connect from a standard client
  3. Cross chunk borders
  4. Experience lag

Your Environment

  • Operating System: Windows 10

Additional Context

The server doesn't seem to be struggling at all and this bug persists even when the server is configured to only send 1 chunk per tick. To experience this effect to the maximum extent, go to x: -800 z: -1000 on the default seed. Notice the multiple fps drops on the second image.
normal
crossing_borders

Activity

  1. Defman commented on Aug 20, 2021

    @Defman
    Defman
    on Aug 20, 2021
    Member
    More actions

    This is most likely do to java being too slow at processing the incoming chunks. In other words, feather is too fast which results in a "dos" like attack on the client. We should add in some rate limiting for chunks or packets in general.

  2. TypicalDarkness commented on Aug 21, 2021

    @TypicalDarkness
    TypicalDarkness
    on Aug 21, 2021
    More actions

    I think this is related to the lighting engine. I had similar issues, but they went away when I installed the phosphor mod. As I understand it, the server currently sends light level 15 for every subchunk that has blocks in it, while the chunks without any blocks have light level 0. Maybe this causes some expensive calculations on the client. In that case, I would expect that they go away once the lighting is implemented properly.

  3. koskja commented on Aug 22, 2021

    @koskja
    koskja
    on Aug 22, 2021
    ContributorAuthor
    More actions

    image
    I think this confirms your theory,

    Reacted by TypicalDarkness
  4. itsTyrion commented on Sep 2, 2021

    @itsTyrion
    itsTyrion
    on Sep 2, 2021
    More actions

    So basically, the slow lighting engine doesn't usually blow up only because the Vanilla server is slow, too? Sounds about right for 1.14+

  5. koskja commented on Sep 3, 2021

    @koskja
    koskja
    on Sep 3, 2021
    ContributorAuthor
    More actions

    So basically, the slow lighting engine doesn't usually blow up only because the Vanilla server is slow, too? Sounds about right for 1.14+

    Actually, the problem is that the client recalculates light for whatever reason when it receives invalid light data. When you generate a vanilla world and load it through feather, no client lag occurs.

  6. 2qar
    added 2 commits that reference this issue on Mar 31, 2022

    anvil+server: load and send sky/block light data

    71b0121

    anvil+server: load and send sky/block light data

    647db60
  7. devashish2024 commented on Nov 15, 2023

    @devashish2024
    devashish2024
    on Nov 15, 2023
    More actions

    I found a way that my whole client lags when ingame if you have smooth fps enabled (under performance in optifine idk about sodium)

  8. devashish2024 commented on Nov 15, 2023

    @devashish2024
    devashish2024
    on Nov 15, 2023
    More actions

    Smooth fps gave me 0fps for long time I struggled then I tried disable it so it worked. It even somehow 0fps at the menus when ingame, such as video settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.