GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Entity equipment by tim-kt · Pull Request #495 · feather-rs/feather

Conversation

@tim-kt

@tim-kt tim-kt commented Sep 28, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Entity equipment

Status

  • Ready
  • Development
  • Hold

Description

This PR implements entity equipment packets (i.e. armor, items in the main hand and off-hand).

Related issues

Closes #494

Checklist

  • Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
  • Removed unnecessary commented out code
  • Used specific traces (if you trace actions please specify the cause i.e. the player)

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
tim-kt added 3 commits September 28, 2021 01:40
@tim-kt
EntityEquipment packets are sent every 10 seconds
a263233 
Fixed typo, added comment
@tim-kt
Better error handling
1fb9579
@tim-kt
EntityEquipment packets are only sent when they're needed (instead of…
46fee12 
… every 10 ticks)
@tim-kt

tim-kt commented Sep 28, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

Missing features:

  • Support for survival
  • Send an EntityEquipment packet to players joining
  • Send EntityEquipment packets for other entites
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tim-kt
tim-kt marked this pull request as draft September 28, 2021 18:47
ambeeeeee
ambeeeeee reviewed Sep 28, 2021
View reviewed changes

@ambeeeeee ambeeeeee left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this isn't done, just wanted to suggest a change.

Awesome work so far, I just have one suggestion that should help prevent bugs since there is a requirement on the struct that cannot be enforced at the type level and thus needs to be enforced manually.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread feather/protocol/src/packets/server/play.rs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread feather/server/src/client.rs Resolved

Uh oh!

There was an error while loading. Please reload this page.
tim-kt added 2 commits September 28, 2021 22:42
@tim-kt
Send entity equipment packets when entities are loaded
dfe8ff1 
Implemented safe EntityEquipment constructor
Removed handle_held_item_change() test
@tim-kt
cargo fmt and private entries in EntityEquipment
8191fd4
@ambeeeeee

ambeeeeee commented Sep 29, 2021

Copy link
Copy Markdown
Contributor

Can you write "Closes #494" so github gets the idea about automatically closing the issue?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tim-kt
Only try to send entity equipment packets for players
31214a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ambeeeeee ambeeeeee ambeeeeee left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Send entity equipment packet

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tim-kt @ambeeeeee
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.