GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Kick the player if the server is outdated by Iaiao · Pull Request #508 · feather-rs/feather

Conversation

@Iaiao

@Iaiao Iaiao commented Dec 5, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Kick the player if the server is outdated

Status

  • Ready
  • Development
  • Hold

Description

Short description what you did and/or fixed

Related issues

Leave empty if none

Checklist

  • Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
  • Removed unnecessary commented out code
  • Used specific traces (if you trace actions please specify the cause i.e. the player)

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Iaiao added 2 commits December 5, 2021 16:13
@Iaiao
Kick the player if the server is outdated
f6e874c
@Iaiao
Run cargo fmt
b65adee
@FussballAndy

FussballAndy commented Jan 5, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

feather/feather/server/src/initial_handler.rs

Lines 48 to 50 in d574826

/// The client should be disconnected (sent when
/// the connection was just a "status" ping.)
Disconnect,

Maybe the documentation of InitialHandling::Disconnect should be changed with this pr, because it is not just used for failed status pings anymore. Btw sorry for making this mistake of only checking one side of Protocol version in the first place. 😅

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Iaiao added 2 commits January 6, 2022 15:15
@Iaiao
Change InitialHandling::Disconnect documentation
6afe350
@Iaiao
Fix
58d2938
Schuwi
Schuwi approved these changes Jan 13, 2022
View reviewed changes

@Schuwi Schuwi left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Defman
Defman requested changes Jan 21, 2022
View reviewed changes
Comment thread feather/server/src/initial_handler.rs

use self::proxy::ProxyData;

const VERSION_STRING: &str = "1.16.5";

@Defman Defman Jan 21, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not available as a constant on the protocol crate, if not it should be added there?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@HttpRafa

HttpRafa commented Feb 5, 2023

Copy link
Copy Markdown

The project is dead

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Defman Defman Defman requested changes
@Schuwi Schuwi Schuwi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Iaiao @FussballAndy @HttpRafa @Defman @Schuwi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.