GeezerVison is showing github.com — Kick the player if the server is outdated by Iaiao · Pull Request #508 · feather-rs/feather
Conversation
Iaiao
commented
Dec 5, 2021
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Kick the player if the server is outdated
Status
Description
Short description what you did and/or fixed
Related issues
Leave empty if none
Checklist
- Ran
cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
- Removed unnecessary commented out code
- Used specific traces (if you trace actions please specify the cause i.e. the player)
Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
FussballAndy
commented
Jan 5, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
/// The client should be disconnected (sent when |
|
/// the connection was just a "status" ping.) |
|
Disconnect, |
Maybe the documentation of InitialHandling::Disconnect should be changed with this pr, because it is not just used for failed status pings anymore. Btw sorry for making this mistake of only checking one side of Protocol version in the first place. 😅
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
|
|
|
|
use self::proxy::ProxyData;
|
|
|
|
|
|
const VERSION_STRING: &str = "1.16.5";
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not available as a constant on the protocol crate, if not it should be added there?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
Defman
Defman requested changes
Schuwi
Schuwi approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.