GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add an ability to change gamemode from plugins by Iaiao · Pull Request #521 · feather-rs/feather

Conversation

@Iaiao

@Iaiao Iaiao commented Jan 17, 2022

Copy link
Copy Markdown
Contributor

Add an ability to change gamemode from plugins

Status

  • Ready
  • Development
  • Hold

Description

Adds GamemodeEvent, InstabreakChangeEvent, FlyingAbilityChangeEvent, BuildingAbilityChangeEvent, and InvulnerabilityChangeEvent. This code was taken from #487 (I had to implement this for /gamemode command), but I think this change deserves a separate PR.

Related issues

Checklist

  • Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
  • Removed unnecessary commented out code
  • Used specific traces (if you trace actions please specify the cause i.e. the player)

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Iaiao added 3 commits January 18, 2022 00:55
@Iaiao
Add GamemodeEvent
1fed01d
@Iaiao
Ignore updates to the same gamemode
2b00410
@Iaiao
Dispatch GamemodeEvent on join
d31fa68
Defman
Defman requested changes Jan 18, 2022
View reviewed changes
Comment thread feather/server/src/client.rs Outdated
pub fn change_gamemode(&self, gamemode: Gamemode) {
self.send_packet(ChangeGameState {
reason: StateReason::ChangeGameMode,
value: gamemode as u8 as f32,

@Defman Defman Jan 18, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the protocol to take Gamemode and implement write on game mode?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Iaiao reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@Iaiao Iaiao Jan 18, 2022

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChangeGameState requires it to be f64, so I did it in a different way.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread feather/server/src/systems/gamemode.rs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread feather/server/src/systems/gamemode.rs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread feather/server/src/systems/gamemode.rs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Iaiao added 5 commits January 18, 2022 23:38
@Iaiao
Simplify abilities change logic
43c44ae
@Iaiao
format
5ea86eb
@Iaiao
Rewrite ChangeGameState packet
46bdd89
@Iaiao
Merge main
26d63b4
@Iaiao
Rename ability change events
8d1d758
Defman
Defman reviewed Jan 19, 2022
View reviewed changes
Comment thread feather/server/src/systems/gamemode.rs Outdated
});
}
for (entity, flying) in fly_changes {
if flying {

@Defman Defman Jan 19, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if statement is redundant, just create CreativeFlyingEvent with the value of flying?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Defman
Defman approved these changes Jan 19, 2022
View reviewed changes
@Iaiao
Remove if statement
3ccbecc
@Defman
Defman merged commit 77f1ace into feather-rs:main Jan 19, 2022
@Iaiao Iaiao mentioned this pull request Jan 20, 2022
Fix state change packet #525
Merged
2 of 6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Defman Defman Defman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Iaiao @Defman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.