GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add events to quill API by Iaiao · Pull Request #522 · feather-rs/feather

Conversation

@Iaiao

@Iaiao Iaiao commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

Add events to quill API

Status

  • Ready
  • Development
  • Hold

Description

This PR changes quill API to make entity_set_component host call accept a variant: u8 param, 0 = insert component, 1 = insert entity event, 2 = insert event. Also adds quill::Game::insert_event and quill::Entity::insert_event

Related issues

Checklist

  • Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
  • Removed unnecessary commented out code
  • Used specific traces (if you trace actions please specify the cause i.e. the player)

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Iaiao
Add events to quill API
15382bb
Defman
Defman requested changes Jan 21, 2022
View reviewed changes
Comment thread feather/plugin-host/src/host_calls/component.rs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Iaiao added 2 commits January 22, 2022 22:52
@Iaiao
Split it into 3 host calls
cb7ffab
@Iaiao
format
334029b
Defman
Defman approved these changes Jan 25, 2022
View reviewed changes
@Defman
Defman merged commit 4d756b3 into feather-rs:main Jan 25, 2022
@Iaiao Iaiao mentioned this pull request Jan 26, 2022
Support for custom tablist header and footer #513
Open
3 of 6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Defman Defman Defman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Iaiao @Defman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.