GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Added data field to the Particle Struct and particles system by leElvyn · Pull Request #529 · feather-rs/feather

Conversation

@leElvyn

@leElvyn leElvyn commented Jan 23, 2022

Copy link
Copy Markdown
Contributor

Added data field to the Particle Struct and particles system

Status

  • Ready
  • Development
  • Hold

Description

  • Added field data: f32 to struct struct Particle.
  • Added that field in send_particle()
  • Added that field to particle-examples

Related issues

Leave empty if none

Checklist

  • Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
  • Removed unnecessary commented out code
  • Used specific traces (if you trace actions please specify the cause i.e. the player)

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
leElvyn added 2 commits January 23, 2022 20:17
@leElvyn
Added data (speed) to particle struct and system
72bb40b
@leElvyn
Correction of attribute names
5b04851
@Iaiao

Iaiao commented Jan 23, 2022

Copy link
Copy Markdown
Contributor

What is particle data? Is it particle speed or what? If so, I think it should be renamed (and also changed on wiki.vg)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oxkitsune

oxkitsune commented Jan 23, 2022

Copy link
Copy Markdown
Member

it usually means speed, but for some particles it changes other stuff like colour fade speed, size variations etc. particle data is fine in my opinion.

not sure why i didnt include it originally when i did the particle stuff

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Iaiao

Iaiao commented Jan 23, 2022

Copy link
Copy Markdown
Contributor

Color transitions, colors, block data and other particle stuff is defined in ParticleKind (https://wiki.vg/Protocol#Particle)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@leElvyn
Merge branch 'feather-rs:main' into main
1e2427b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@leElvyn @Iaiao @oxkitsune
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.