GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update hecs to upstream 0.7 by Plecra · Pull Request #533 · feather-rs/feather

Conversation

@Plecra

@Plecra Plecra commented Feb 8, 2022

Copy link
Copy Markdown

Status

  • Ready
  • Development
  • Hold

Description

I have bumped the hecs version to 0.7, and removed the dependency on the git version.

This mostly involved small changes to compensate for Entity::from_bits being fallible now. The biggest change was reimplementing the DynamicQuery logic (from feather-rs/feather-hecs@87d8d00) in-tree.

The new implementation should behave identically to the old code, with a couple small optimizations. There is room for more optimization too :) This is the change that I hope someone can fully review

Related issues

Checklist

  • Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
  • Removed unnecessary commented out code
  • Used specific traces (if you trace actions please specify the cause i.e. the player)

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Plecra added 2 commits February 8, 2022 00:36
@Plecra
update hecs dependency to upstream
b7189c1
@Plecra
update references to old hecs APIs
bd30e34
@Plecra Plecra mentioned this pull request Feb 8, 2022
Reducing Compile Time #531
Open
@Plecra
Plecra force-pushed the update-hecs branch from 93f581d to 811ab0e Compare February 8, 2022 01:38
Plecra added 2 commits February 8, 2022 10:23
@Plecra
reimplement dynamic archetype queries
bd57f95
@Plecra
update lockfile
1e23ff6
@Plecra
Plecra force-pushed the update-hecs branch from 811ab0e to 1e23ff6 Compare February 8, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Plecra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.