GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use cargo deny in CI by Plecra · Pull Request #538 · feather-rs/feather

Conversation

@Plecra

@Plecra Plecra commented Feb 8, 2022

Copy link
Copy Markdown

Status

  • Ready
  • Development
  • Hold

Description

As mentioned in #531 (comment), I've setup the repo to use cargo deny. It is now correctly checking everything, and allowing for a set of exceptions in deny.toml.

All that's left is adding a workflow for running the tool.

Related issues

Leave empty if none

Checklist

  • Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
  • Removed unnecessary commented out code
  • Used specific traces (if you trace actions please specify the cause i.e. the player)

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Plecra added 5 commits February 8, 2022 11:10
@Plecra
add configuration for cargo-deny
24fc44b
@Plecra
add dependencies' licenses to cargo-deny
0f3d645
@Plecra
whitelist github sources
471c267
@Plecra
add license attribute to all Cargo.toml files
52db1c1
@Plecra
allow existing duplicated dependencies
2698e45
@Iaiao

Iaiao commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

quill is licensed under Apache 2.0 or MIT

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Plecra

Plecra commented Feb 8, 2022

Copy link
Copy Markdown
Author

Right, I was surprised about that :) I couldn't find an explicit mention of the MIT license in the repo - where is Apache+MIT declared?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Iaiao

Iaiao commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

There are quill/LICENSE-APACHE and quill/LICENSE-MIT. There's no explicit mention of dual licensing in README.md and Cargo.toml though, so I'm not sure about that. @caelunshun is quill dual licensed, or why is there 2 license files?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Plecra @Iaiao
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.