GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Add `divide` icons by csandman · Pull Request #568 · feathericons/feather

Conversation

@csandman

@csandman csandman commented Apr 2, 2019

Copy link
Copy Markdown
Contributor

Added 3 division icons (also knows as an obelus). One by itself, one with a circle around it, and one with a square around it. These are meant to compliment the plus, minus, and x icons and fill out the set of math icons.

Screenshot 2019-04-01 21 13 06

The shapes are composed the same way as they are in the other math icons, using 1px lines for the points.

Closes #263

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jonahallibone, moeenio, LouizFC, ElForastero, and hacknug reacted with thumbs up emoji
All reactions
  • 👍 5 reactions
@csandman
feat: Add divide icons
e92abf3
Added 3 division icons (also knows as an obelus).  One by itself, one with a circle around it, and one with a square around it.  These are meant to compliment plus, minus, and x icons.
@codecov

codecov Bot commented Apr 2, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #568 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #568   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           34        34           
  Branches         3         3           
=========================================
  Hits            34        34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca4f12...a29060e. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@moeenio moeenio mentioned this pull request Apr 2, 2019
Icon Request: divide #263
Closed
@colebemis

colebemis commented Jun 5, 2019

Copy link
Copy Markdown
Member

@csandman These look great! Thanks for opening a PR 🎉

My only feedback is that the dots on the divide icon might be a little small relative to the rest of the icon:

image

Could you try a version that uses a larger circle similar to the percent icon?

image

moeenio reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@csandman

csandman commented Jul 11, 2019

Copy link
Copy Markdown
Contributor Author

divide

@colebemis Sorry I saw your comment so late! I gave it a shot, is this what you were thinking of?

The main reason I avoided this is because I felt that the circles were a bit too large but its up to you.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mittalyashu

mittalyashu commented Jul 22, 2019

Copy link
Copy Markdown
Contributor

@csandman If you zoom out the divide icon looks perfect with bigger dots.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ElForastero

ElForastero commented Feb 29, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Yeah, it looks a little bit thin compared to other icons.

But I still love it 😉

image

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

csandman and others added 2 commits March 3, 2020 09:37
@csandman
Merge pull request #1 from feathericons/master
758a547
Update branch with master
@csandman
Update divide icon to meet specifications
a29060e
@csandman

csandman commented Mar 3, 2020

Copy link
Copy Markdown
Contributor Author

I know this is rather old, but I never pushed my change with the change requested by @colebemis

Anyway, now I have so feel free to merge if you like the change!

Here is what all 3 icons look like in context of the other icons:
Frame 1

ElForastero reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

colebemis
colebemis approved these changes Apr 4, 2020
View reviewed changes

@colebemis colebemis left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @csandman! ❤️

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

csandman reacted with laugh emoji moeenio reacted with heart emoji
All reactions
  • 😄 1 reaction
  • ❤️ 1 reaction
@colebemis
colebemis merged commit 9e0dcca into feathericons:master Apr 4, 2020
@snyk-bot snyk-bot mentioned this pull request Apr 7, 2020
[Snyk] Upgrade feather-icons from 4.26.0 to 4.28.0 distributeaid/chat-ui#35
Merged
@dgdavid dgdavid mentioned this pull request Apr 21, 2020
Discussion: Repo needs more moderators #893
Open
@csandman
csandman deleted the add-division-icons branch April 27, 2020 16:19
FirstLast94397
FirstLast94397 approved these changes Dec 30, 2021
View reviewed changes
@valdisiljuconoks valdisiljuconoks mentioned this pull request May 22, 2024
[Snyk] Upgrade feather-icons from 4.28.0 to 4.29.2 valdisiljuconoks/Foundation#53
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colebemis colebemis colebemis approved these changes
+1 more reviewer
@FirstLast94397 FirstLast94397 FirstLast94397 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Icon Request: divide

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@csandman @colebemis @mittalyashu @ElForastero @FirstLast94397
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.