GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Feature: Add pin and pin-vertical by junipf · Pull Request #626 · feathericons/feather

Conversation

@junipf

@junipf junipf commented Jun 21, 2019

Copy link
Copy Markdown

pin
pin-vertical
Used guidelines in #171
Fixes #407

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mrbbot reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Paige added 2 commits June 20, 2019 23:03
Paige
feat: Add pin and pin-vertical
277fda5
Paige
fix: Stroke alginment fixed, unintended class attribute removed
d57e7f5
@codecov

codecov Bot commented Jun 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #626 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #626   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c64e93...d57e7f5. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

moeenio
moeenio approved these changes Jun 21, 2019
View reviewed changes
@jletey jletey mentioned this pull request Jun 23, 2019
Icon Request: Pinboard #605
Open
@MarcelloTheArcane

MarcelloTheArcane commented Jul 19, 2019

Copy link
Copy Markdown
Contributor

Could you try it with the tops slightly narrower? Just an idea 🙂

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

moeenio
moeenio approved these changes Jul 19, 2019
View reviewed changes

@moeenio moeenio left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe renaming to pin-2 ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MarcelloTheArcane reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@mittalyashu

mittalyashu commented Jul 22, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@junipf Keep the vertical pin name as pin and change the tilted pin name to pin-tilted.
What do you think? @locness3

The size of this titled pin is bigger as compared to the vertical pin.

image

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@moeenio

moeenio commented Jul 22, 2019

Copy link
Copy Markdown

pin-titled ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mittalyashu

mittalyashu commented Jul 22, 2019

Copy link
Copy Markdown
Contributor

Sorry, I mean pin-tilted. 😅

mittalyashu reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@moeenio

moeenio commented Jul 22, 2019

Copy link
Copy Markdown

Oh ok.

mittalyashu reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@junipf

junipf commented Jul 23, 2019

Copy link
Copy Markdown
Author

The size of this titled pin is bigger as compared to the vertical pin.

They're sized to have at least 1px between the icon and the edge of the canvas per the guidelines. So long as they aren't used together (which they reasonably shouldn't be), I think this is preferable.

I'm fine with any renaming

moeenio reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ahtohbi4

ahtohbi4 commented Jul 24, 2019

Copy link
Copy Markdown
Contributor

For my project, I have made the other ones:

Снимок экрана 2019-07-24 в 11 46 48

Снимок экрана 2019-07-24 в 11 55 33

But yours are nice too. ☺️

junipf reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@moeenio

moeenio commented Jul 24, 2019

Copy link
Copy Markdown

They look a lot detailed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mittalyashu

mittalyashu commented Jul 24, 2019

Copy link
Copy Markdown
Contributor

Let's add all of them.

Just to keep the shape of the pin consistent, can some copy the pinhead from an icon to another.

MarcelloTheArcane reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MarcelloTheArcane

MarcelloTheArcane commented Jul 24, 2019

Copy link
Copy Markdown
Contributor

@ahtohbi4 Could you increase the gap of the top ridge?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ahtohbi4

ahtohbi4 commented Jul 24, 2019

Copy link
Copy Markdown
Contributor

Let's add all of them.

@mittalyashu I don't think that it is a good idea to store a million kind of the same icons. It will turn a collection of good icons into a dump. 😌

@ahtohbi4 Could you increase the gap of the top ridge?

@MarcelloTheArcane I can give you SVG-code of my variants if you'd like.

moeenio reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mittalyashu

mittalyashu commented Jul 24, 2019

Copy link
Copy Markdown
Contributor

@mittalyashu I don't think that it is a good idea to store a million kind of the same icons. It will turn a collection of good icons into a dump. 😌

But I love both icons 😭.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@junipf

junipf commented Jul 24, 2019

Copy link
Copy Markdown
Author

Those are really great @ahtobi4! I think the head shape on yours are a lot more readable than mine, but they might be a bit noisey, so I'd love to play around with them and hopefully sort of merge our designs if you wouldn't mind.

mittalyashu reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ahtohbi4

ahtohbi4 commented Jul 24, 2019

Copy link
Copy Markdown
Contributor

so I'd love to play around with them and hopefully sort of merge our designs if you wouldn't mind.

@junipf sure 🙂

Here is the code:

<svg
  xmlns="http://www.w3.org/2000/svg"
  width="24"
  height="24"
  viewBox="0 0 24 24"
  fill="none"
  stroke="currentColor"
  stroke-width="2"
  stroke-linecap="round"
  stroke-linejoin="round"
>
  <path d="M15 5a2 2 0 0 0 2-2V2H7v1c0 1.1.9 2 2 2m6 0l1 7m-1-7H9m7 7H8m8 0s3 .5 3 4H5c0-3.5 3-4 3-4m0 0l1-7M12 16v6" />
</svg>
<svg
  xmlns="http://www.w3.org/2000/svg"
  width="24"
  height="24"
  viewBox="0 0 24 24"
  fill="none"
  stroke="currentColor"
  stroke-width="2"
  stroke-linecap="round"
  stroke-linejoin="round"
>
  <path d="M17.85 10.2l-4.24 5.65m4.24-5.66L13.6 5.95m4.24 4.24a2 2 0 0 0 2.83 0l.7-.7-7.07-7.08-.7.71a2 2 0 0 0 0 2.83m0 9.9l-5.66-5.66m5.66 5.66s1.76 2.47-.71 4.95L3 10.9c2.47-2.48 4.95-.7 4.95-.7m0 0l5.66-4.25M7.95 15.85l-4.24 4.24" />
</svg>
mittalyashu and westmark reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dgdavid dgdavid mentioned this pull request Apr 21, 2020
Discussion: Repo needs more moderators #893
Open

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@moeenio moeenio moeenio approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Icon Request: Pin

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@junipf @MarcelloTheArcane @mittalyashu @moeenio @ahtohbi4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.