GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor(commons): use named exports by fratzinger · Pull Request #3496 · feathersjs/feathers

Conversation

@fratzinger

@fratzinger fratzinger commented Jun 2, 2024

Copy link
Copy Markdown
Member
  • export every function directly
  • improve 'some' & 'every' for early exit
  • use 'Object.values' for 'values' instead of 'Object.keys.map' (2x perf)
  • isObject: first check for null
  • named imports from @feathersjs/commons in every package
  • deprecate 'keys', use Object.keys
  • deprecate 'values', use Object.values
  • deprecate 'extend', use Object.assign
  • use type guard for isPromise, isObject & isObjectOrArray
  • add jsdoc comments

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@fratzinger
refactor(commons): use named exports
3ef1cd7 
- export every function directly
- improve 'some' & 'every' for early exit
- use 'Object.values' for 'values' instead of 'Object.keys.map' (2x perf)
- isObject: first check for null
- named imports from @feathersjs/commons in every package
- deprecate 'keys', use `Object.keys`
- deprecate 'values', use `Object.values`
- deprecate 'extend', use `Object.assign`
- use type guard for `isPromise`, `isObject` & `isObjectOrArray`
- add jsdoc comments
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 2, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Deploying feathers-dove with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5f05516
Status: ✅  Deploy successful!
Preview URL: https://240c0d13.feathers.pages.dev
Branch Preview URL: https://refactor-commons-named-expor.feathers.pages.dev

View logs
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
fratzinger added 3 commits June 2, 2024 18:50
@fratzinger
fix: module.exports hack assign for cjs
c333806
@fratzinger
chore: export default _
83413ad
@fratzinger
Merge branch 'dove' into refactor/commons-named-export
e84edd0
daffl
daffl approved these changes Aug 19, 2025
View reviewed changes
@daffl
Merge branch 'dove' of github.com:feathersjs/feathers into refactor/c…
5f05516 
…ommons-named-export

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daffl daffl daffl approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@fratzinger @daffl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.