GeezerVison is showing github.com — feat: Add externalMethods option for transport exposure (#3457) by marshallswain · Pull Request #3637 · feathersjs/feathers
Conversation
Summary
This PR adds support for the externalMethods option to control which service methods are exposed via transports (HTTP/WebSockets), addressing #3457.
Changes
@feathersjs/feathers
- Added
externalMethods to ServiceOptions interface
- Added
getExternalMethods() helper function
- Updated
normalizeServiceOptions() to include externalMethods (defaults to methods for backwards compatibility)
@feathersjs/transport-commons
- Updated
socket/utils.ts to use externalMethods for method validation
- Updated
socket/index.ts to use externalMethods for handler registration
Usage
app.use('myService', new MyService(), {
// Methods that receive 'all' hooks
methods: ['find', 'get', 'create', 'internalAction'],
// Methods exposed via transports (defaults to methods if not specified)
externalMethods: ['find', 'get', 'create']
})Backwards Compatibility
- If
externalMethods is not specified, it defaults to methods
- Existing code works without modification
Related
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
- Add externalMethods to ServiceOptions to control transport exposure
- Add getExternalMethods() helper function
- Update transport-commons socket transport to use externalMethods
- Backwards compatible: externalMethods defaults to methods
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.