GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(commons): skip prototype-polluting keys in _.merge by marshallswain · Pull Request #3695 · feathersjs/feathers

Conversation

@marshallswain

@marshallswain marshallswain commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary

Backport of the Dove fix for GHSA-28xv-ph75-77wh / CVE-2026-54335 to Crow (Feathers 4.x).

The recursive _.merge helper in @feathersjs/commons iterates Object.keys(source). When the source came from JSON.parse('{"__proto__":...}'), __proto__ is returned as an own-enumerable key, so the recursive call resolves target['__proto__'] to Object.prototype and writes onto it.

This adds the standard guard to skip __proto__, constructor, and prototype keys during iteration — the same remediation as dove #3690 / @feathersjs/[email protected].

  • Tell us about the problem your pull request is solving.
  • Are there any open issues that are related to this?
  • Is this PR dependent on PRs in other repos?

Related: #3690 (dove), #3687 (original report by @ridingsa), GHSA-28xv-ph75-77wh.

No dependency on other repos.

Changes

  • packages/commons/src/utils.ts: skip the three prototype-mutating keys in the merge loop.
  • packages/commons/test/utils.test.ts: regression test confirming a JSON-parsed __proto__ / constructor.prototype source no longer mutates Object.prototype.

Notes

  • No public API change — merge still works for all documented input shapes.
  • After merge, publish @feathersjs/[email protected] (and bump dependents as needed for the Crow release), then update GHSA-28xv-ph75-77wh with a Crow patched range (<= 4.5.19 → 4.5.20).

Reported-by: Andrew Ridings (@ridingsa)

Verification

cd packages/commons && npm test
# 53 passing

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@marshallswain
fix(commons): skip prototype-polluting keys in _.merge
e6abffc
Object.keys() returns __proto__ as an own enumerable key for
JSON-parsed sources, causing the recursive merge to write onto
Object.prototype. Skip __proto__/constructor/prototype keys.

Same remediation as dove #3690 / @feathersjs/[email protected]
(GHSA-28xv-ph75-77wh / CVE-2026-54335).

Reported-by: Andrew Ridings (@ridingsa)
@marshallswain
marshallswain merged commit 88794cc into crow Aug 10, 2026
2 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@marshallswain
marshallswain deleted the fix/commons-merge-proto-pollution-crow branch August 10, 2026 17:10
@marshallswain marshallswain mentioned this pull request Aug 16, 2026
Improve GHSA-28xv-ph75-77wh: add Crow 4.x patched range github/advisory-database#9137
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@marshallswain
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.