GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(generators): add targeted pnpm build approval for sqlite3 and esbuild by akasakariko · Pull Request #3710 · feathersjs/feathers

Conversation

@akasakariko

@akasakariko akasakariko commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Fixes #3709

Summary

  • Pass targeted --allow-build=sqlite3 when installing sqlite3 under pnpm
  • Pass targeted --allow-build=esbuild when installing @feathersjs/cli under pnpm because the CLI TypeScript loader requires esbuild
  • Support both versioned and unversioned package requests while avoiding false matches on similarly named packages
  • Keep npm and yarn install commands unchanged
  • Avoid blanket script execution permissions and preserve standard install failure propagation

Testing

  • Verified failure before fix: pnpm 12.9.1 threw ERR_PNPM_IGNORED_BUILDS on [email protected], blocking devDependencies installation, and blocked esbuild postinstall in CLI dependencies
  • Added 19 regression tests in packages/generators/test/install.test.ts for npm, yarn, and pnpm argument composition, versioned and unversioned requests, callable arguments, and error propagation
  • Ran 20 focused tests on Node 20 and Node 24
  • Passed all 60 generator tests across JavaScript, TypeScript, Koa, Express, TypeBox, and JSON schema combinations
  • Verified default app generation with pnpm 12.9.1: confirmed devDependencies present, verified native SQLite query execution, passed pnpm test (3 passing), and ran pnpm run compile
  • Verified monorepo compilation for all 25 projects, Prettier, ESLint, and git diff --check
  • GitHub CI has not yet run and the full monorepo test suite was not run locally

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@akasakariko
fix(generators): approve required pnpm dependency builds
d1bee70

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pnpm project missing dev dependencies

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@akasakariko
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.