GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — chore: Migrate to ESLint 10 flat config with @feathers-community/eslint-config (v6) by fratzinger · Pull Request #3721 · feathersjs/feathers Conversation
Member
SummaryThe legacy -.eslintrc.js +eslint.config.mjs # @feathers-community/eslint-config + Feathers overrides package.json - "eslint": "ESLINT_USE_FLAT_CONFIG=false eslint \"packages/**/*.ts\" --fix" + "eslint": "eslint packages --fix" - eslint@9, @typescript-eslint/*, eslint-config-prettier, eslint-plugin-prettier + eslint@10, @feathers-community/eslint-config, globals The overrides in
The code changes in the other files are the safe autofixes: separate type imports, the
There are no behaviour changes. Depends on #3720. Evidence
Merge DangerDoor: two-way Blast Radius: small The PR touches 65 files, but outside the dev tooling every change is mechanical, mostly import statements, and the test suite passes unchanged. Most of the added lines are in 🤖 Generated with Claude Code
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsNode.js 20 is end-of-life and the development tooling (ESLint plugins) already requires newer versions. All packages now require Node.js 24 or later and CI tests on Node.js 24 and 26. Co-Authored-By: Claude Opus 5.5 <[email protected]> …nt-config (v6) - Replace the legacy `.eslintrc.js` (which required `ESLINT_USE_FLAT_CONFIG=false` and no longer works with ESLint 10) with `eslint.config.mjs` based on `@feathers-community/eslint-config` - Keep the existing `.prettierrc` formatting options - Disable `e18e/prefer-spread-syntax` (`[].concat(x)` and `[...x]` behave differently when `x` is not an array) and the e18e rules that require ES2022+ since Feathers targets ES2020 (browsers, React Native) - Apply the autofixes (type imports, `node:` protocol, `assert.ok`, ...) and fix the remaining issues by hand (empty catch blocks, `hasOwnProperty`, template arguments) Co-Authored-By: Claude Opus 5.5 <[email protected]>
This was referenced
This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |