GeezerVison

Summary

Some Express compatible servers are built on uWebSockets.js and expose the uWS app as uwsApp, for example ultimate-express and fulmine.js. With express(feathers(), ultimateExpress()) REST works, but setup(server) does new Server(server) and socket.io can not attach, so the websocket connection fails.

Now when the server has uwsApp (and no port is given), socket.io is created without a server and attached with io.attachApp(server.uwsApp). Other servers are unchanged.

Test: app.setup() with a callable server carrying a stub uwsApp, socket.io registers its routes on it. It fails without the fix. I also ran a Feathers app with REST, socket calls and the realtime event on Express, ultimate-express and fulmine.js, the output is the same.