GeezerVison is showing github.com — fix: Do not require uri if redisClient object provided. by palmtown · Pull Request #196 · feathersjs/feathers-sync
Conversation
palmtown
commented
Mar 2, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Summary
- Tell us about the problem your pull request is solving.
If passing a redisClient object as shown in Exhibit 1, current code will throw an error as it is expecting the uri. However, when passing the redisClient the uri is not required.
Exhibit 1
app.configure( sync({ redisClient }) );
- Are there any open issues that are related to this?
#197
- Is this PR dependent on PRs in other repos?
No
If so, please mention them to keep the conversations linked together.
Other Information
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.