GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Try to guess context data that's required down stream by mrfrase3 · Pull Request #199 · feathersjs/feathers-sync

Conversation

@mrfrase3

@mrfrase3 mrfrase3 commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

Summary

Currently if you need to manually submit an event, like you want to push an update after calling _patch, this lib requires you to build a context object manually or else it wont work properly:

const newItem = await app.service(path)._patch(item._id, data);
app.service(path).emit('patched', newItem, { method: 'patch', id: item._id, result: newItem, path, params: {} });

most of the required info in context can already be gleaned from the execution context, so the code in this PR attempts a best guess context object. Whilst not perfect, it at least protects the developer from forgetting a fixed set of fields:

app.service(path).emit('patched', newItem);

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
mrfrase3 added 2 commits March 8, 2024 12:23
@mrfrase3
Try to guess context data that's required down stream
2ac1519
@mrfrase3
testing fixes
b0af9ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@mrfrase3
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.