GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Explain the persistent overlays in the profiler layout · feldera/feldera@68af1c1

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • js-packages/profiler-layout/src/lib/components
    • SupportBundleViewerLayout.svelte
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎js-packages/profiler-layout/src/lib/components/SupportBundleViewerLayout.svelte‎

Copy file name to clipboardExpand all lines: js-packages/profiler-layout/src/lib/components/SupportBundleViewerLayout.svelte
+11-8Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -165,16 +165,19 @@
165165
)
166166
let highlightRanges: SourcePositionRange[] = $state([])
167167
168-
// The graph panel's diagram is hoisted to a <PersistentContent> overlay so it survives the
169-
// sqlPanelFullHeight layout toggle (which would otherwise unmount/remount the snippet's
170-
// <ProfilerDiagram>, discarding the Visualizer's state). The graphPanel snippet renders a
171-
// <PersistentPlaceholder> that mirrors its bounding rect onto this shared handle.
168+
// The <ProfilerDiagram> is not rendered inside the graphPanel snippet. It is rendered once, at
169+
// the root of this component, in a <PersistentContent> overlay with a fixed position. The overlay
170+
// follows the position and size of an empty placeholder div in the graphPanel snippet. Thus the
171+
// sqlPanelFullHeight layout toggle moves only the placeholder, and the diagram keeps the
172+
// Visualizer's state. The placeholder div uses `diagramRect.placeholder` to report its bounding
173+
// rect to this shared handle.
172174
const diagramRect = usePersistentRect()
173175
174-
// The code panel is hoisted the same way. The layout toggle swaps the {#if} branch that renders
175-
// the panel, and Svelte mounts the new branch before it destroys the old branch. An inline panel
176-
// would then create a second Monaco model with the same URI, which Monaco rejects. Each layout
177-
// branch renders only a placeholder.
176+
// The code panel is also rendered once in an overlay at the root, not inside the layout branches.
177+
// The layout toggle swaps the {#if} branch that renders the panel, and Svelte mounts the new
178+
// branch before it destroys the old branch. A panel inside each branch would then create a second
179+
// Monaco model with the same URI, which Monaco rejects. Each layout branch renders only a
180+
// placeholder.
178181
const sourcePanelRect = usePersistentRect()
179182
180183
const lookup = createLookupCoordinator()

0 commit comments

Comments
0 (0)
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.