GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove redundant classes, other minor fixes · feldera/feldera@d65d080

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • js-packages
    • common-ui/src/lib
      • ConnectorMetricsTables.svelte
      • SegmentedControl.svelte
    • profiler-layout/src/lib/components
      • MetricSelect.svelte
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎js-packages/common-ui/src/lib/ConnectorMetricsTables.svelte‎

Copy file name to clipboardExpand all lines: js-packages/common-ui/src/lib/ConnectorMetricsTables.svelte
+29-27Lines changed: 29 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@
293293
{/snippet}
294294

295295
{#snippet connectorName(name: string)}
296-
<span class="relative h-[20px] min-w-0 flex-1 overflow-hidden">
296+
<span class="relative h-5 min-w-0 flex-1 overflow-hidden">
297297
<span class="absolute inset-0 overflow-hidden text-left text-nowrap text-ellipsis" dir="rtl">
298298
{name}
299299
</span>
@@ -310,7 +310,7 @@
310310
aria-label="Unhealthy"
311311
class="fd fd-triangle-alert absolute top-1/2 right-full mr-1 -translate-y-1/2 cursor-pointer text-[16px] leading-none text-(--latency-slow)"
312312
></span>
313-
<Popover class="z-20 max-w-lg text-[14px] leading-[20px]">
313+
<Popover class="z-20 max-w-lg">
314314
<div class="flex flex-nowrap items-start gap-4">
315315
{#if description}
316316
<span class="min-w-0 flex-1 wrap-break-word whitespace-pre-wrap">
@@ -494,20 +494,20 @@
494494
relation?: string,
495495
connectorEndpointName?: string
496496
)}
497-
<td class="text-end font-dm-mono text-[14px] text-nowrap {numberWidth.records}"
497+
<td class="text-end font-dm-mono text-nowrap {numberWidth.records}"
498498
><span class={ioActive ? 'text-success-600-400' : ''}>{formatQty(m.total_records)}</span></td
499499
>
500-
<td class="text-end font-dm-mono text-[14px] text-nowrap {numberWidth.bytes}"
500+
<td class="text-end font-dm-mono text-nowrap {numberWidth.bytes}"
501501
><span class={ioActive ? 'text-success-600-400' : ''}>{@render bytes(m.total_bytes)}</span></td
502502
>
503-
<td class="text-end font-dm-mono text-[14px] text-nowrap {numberWidth.bufferedRecords} {bufferedGap}"
503+
<td class="text-end font-dm-mono text-nowrap {numberWidth.bufferedRecords} {bufferedGap}"
504504
>{formatQty(m.buffered_records)}</td
505505
>
506-
<td class="text-end font-dm-mono text-[14px] text-nowrap {numberWidth.bufferedBytes}"
506+
<td class="text-end font-dm-mono text-nowrap {numberWidth.bufferedBytes}"
507507
>{@render bytes(m.buffered_bytes)}</td
508508
>
509509
<td
510-
class="text-end font-dm-mono text-[14px] text-nowrap {numberWidth.groupLatency} {groupGap}"
510+
class="text-end font-dm-mono text-nowrap {numberWidth.groupLatency} {groupGap}"
511511
data-testid="box-input-latency-p99"
512512
>
513513
{#if typeof m.processing_latency_p99_micros === 'number'}
@@ -523,7 +523,7 @@
523523
{/if}
524524
</td>
525525
<td
526-
class="text-end font-dm-mono text-[14px] text-nowrap {numberWidth.groupCount} {groupGap} {m.num_parse_errors >
526+
class="text-end font-dm-mono text-nowrap {numberWidth.groupCount} {groupGap} {m.num_parse_errors >
527527
0
528528
? 'text-error-500'
529529
: ''}"
@@ -542,7 +542,7 @@
542542
{/if}
543543
</td>
544544
<td
545-
class="text-end font-dm-mono text-[14px] text-nowrap {numberWidth.count} {m.num_transport_errors >
545+
class="text-end font-dm-mono text-nowrap {numberWidth.count} {m.num_transport_errors >
546546
0
547547
? 'text-error-500'
548548
: ''}"
@@ -588,32 +588,32 @@
588588
relation?: string,
589589
connectorEndpointName?: string
590590
)}
591-
<td class="text-end font-dm-mono text-[14px] text-nowrap {numberWidth.records}"
591+
<td class="text-end font-dm-mono text-nowrap {numberWidth.records}"
592592
><span class={ioActive ? 'text-success-600-400' : ''}>{formatQty(m.transmitted_records)}</span
593593
></td
594594
>
595-
<td class="text-end font-dm-mono text-[14px] text-nowrap {numberWidth.records}"
595+
<td class="text-end font-dm-mono text-nowrap {numberWidth.records}"
596596
><span class={ioActive ? 'text-success-600-400' : ''}
597597
>{m.batch_records_written != null ? formatQty(m.batch_records_written) : '—'}</span
598598
></td
599599
>
600-
<td class="text-end font-dm-mono text-[14px] text-nowrap {numberWidth.bytes}"
600+
<td class="text-end font-dm-mono text-nowrap {numberWidth.bytes}"
601601
><span class={ioActive ? 'text-success-600-400' : ''}>{@render bytes(m.transmitted_bytes)}</span
602602
></td
603603
>
604-
<td class="text-end font-dm-mono text-[14px] text-nowrap {numberWidth.bufferedRecords} {bufferedGap}"
604+
<td class="text-end font-dm-mono text-nowrap {numberWidth.bufferedRecords} {bufferedGap}"
605605
>{formatQty(m.buffered_records)}</td
606606
>
607-
<td class="text-end font-dm-mono text-[14px] text-nowrap {numberWidth.count}"
607+
<td class="text-end font-dm-mono text-nowrap {numberWidth.count}"
608608
>{formatQty(m.buffered_batches)}</td
609609
>
610-
<td class="text-end font-dm-mono text-[14px] text-nowrap {numberWidth.records}"
610+
<td class="text-end font-dm-mono text-nowrap {numberWidth.records}"
611611
>{formatQty(m.queued_records)}</td
612612
>
613-
<td class="text-end font-dm-mono text-[14px] text-nowrap {numberWidth.count}"
613+
<td class="text-end font-dm-mono text-nowrap {numberWidth.count}"
614614
>{formatQty(m.queued_batches)}</td
615615
>
616-
<td class="text-end font-dm-mono text-[14px] text-nowrap {numberWidth.groupCount} {groupGap}">
616+
<td class="text-end font-dm-mono text-nowrap {numberWidth.groupCount} {groupGap}">
617617
{#if m.num_encode_errors > 0 && relation && connectorEndpointName && onConnectorSelect}
618618
<button
619619
data-testid="btn-encode-errors"
@@ -627,7 +627,7 @@
627627
{formatQty(m.num_encode_errors)}
628628
{/if}
629629
</td>
630-
<td class="text-end font-dm-mono text-[14px] text-nowrap {numberWidth.count}">
630+
<td class="text-end font-dm-mono text-nowrap {numberWidth.count}">
631631
{#if m.num_transport_errors > 0 && relation && connectorEndpointName && onConnectorSelect}
632632
<button
633633
data-testid="btn-output-transport-errors"
@@ -738,7 +738,11 @@
738738
<div class="latency-colors w-full {maxWidth}" data-testid={testId}>
739739
<div class="scrollbar w-full overflow-x-auto">
740740
<div class="bg-white-dark w-max min-w-full overflow-hidden rounded">
741-
<table class="metrics-table table h-min w-full text-[14px] leading-[20px]">
741+
<!-- Header cells fit two 20px lines plus padding, in 14px font like the rows. The header
742+
line and the row lines share one tone. -->
743+
<table
744+
class="table h-min w-full text-base"
745+
>
742746
<thead>
743747
{@render columnHeaders(chevronGutter, [...allData.keys()])}
744748
</thead>
@@ -831,24 +835,22 @@
831835
<style>
832836
/* Header cells fit two 20px lines plus padding, in 14px type like the rows. The header
833837
line and the row lines share one tone. */
834-
.metrics-table :global(th) {
838+
.table :global(th) {
835839
padding: 0.5rem;
836840
height: 56px;
837841
vertical-align: middle;
838-
font-size: 0.875rem;
839-
line-height: 1.25rem;
840842
font-weight: 500;
841843
text-align: start;
842844
}
843-
.metrics-table :global(td) {
845+
.table :global(td) {
844846
padding-inline: 0.5rem;
845847
}
846-
.metrics-table :global(thead),
847-
.metrics-table :global(tr) {
848+
.table :global(thead),
849+
.table :global(tr) {
848850
border-color: var(--color-surface-100);
849851
}
850-
:global(.dark) .metrics-table :global(thead),
851-
:global(.dark) .metrics-table :global(tr) {
852+
:global(.dark) .table :global(thead),
853+
:global(.dark) .table :global(tr) {
852854
border-color: var(--color-surface-900);
853855
}
854856

Collapse file

‎js-packages/common-ui/src/lib/SegmentedControl.svelte‎

Copy file name to clipboardExpand all lines: js-packages/common-ui/src/lib/SegmentedControl.svelte
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@
3636
SegmentedControlSize,
3737
{ control: string; radius: string; item: string }
3838
> = {
39-
sm: { control: 'h-6', radius: 'rounded-md', item: 'gap-1 px-3 text-[12px] leading-4' },
40-
md: { control: 'h-8', radius: 'rounded-md', item: 'gap-2 px-4 text-[14px] leading-5' },
41-
lg: { control: 'h-10', radius: 'rounded-lg', item: 'gap-2 px-4 text-[16px] leading-6' }
39+
sm: { control: 'h-6', radius: 'rounded-md', item: 'gap-1 px-3 text-sm leading-4' },
40+
md: { control: 'h-8', radius: 'rounded-md', item: 'gap-2 px-4 text-base leading-5' },
41+
lg: { control: 'h-10', radius: 'rounded-lg', item: 'gap-2 px-4 text-lg leading-6' }
4242
}
4343
</script>
4444

Collapse file

‎js-packages/profiler-layout/src/lib/components/MetricSelect.svelte‎

Copy file name to clipboardExpand all lines: js-packages/profiler-layout/src/lib/components/MetricSelect.svelte
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
>
5050
<Combobox.Control>
5151
<Combobox.Input
52-
class="h-6 border-none bg-surface-100-900/50 py-0 pr-7 pl-2 text-[14px] ring-0"
52+
class="h-6 border-none bg-surface-100-900/50 py-0 pr-7 pl-2 ring-0"
5353
{title}
5454
/>
5555
<Combobox.Trigger class="right-0.5 size-5 min-h-0 min-w-0 bg-transparent p-0">
@@ -59,7 +59,7 @@
5959
<Portal>
6060
<Combobox.Positioner>
6161
<!-- The positioner copies its z-index from the content (`z-2`). -->
62-
<Combobox.Content class="scrollbar z-2 max-h-96 gap-0 overflow-y-auto p-1 text-[14px]">
62+
<Combobox.Content class="scrollbar z-2 max-h-96 gap-0 overflow-y-auto p-1">
6363
{#each matching as metric (metric.id)}
6464
<Combobox.Item item={metric} class="py-0.5">
6565
<Combobox.ItemText>{metric.label}</Combobox.ItemText>

0 commit comments

Comments
0 (0)
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.