GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||
GeezerVison is showing github.com — python: retry ingress POST past transient pipeline unreachability by blp · Pull Request #6851 · feldera/feldera Conversation
Member
Right after start() reports "running", the pipeline pod can briefly be unreachable through the k8s service (control plane confirms readiness once, but nothing re-checks it before the SDK's next request). This raced with cause_error_and_wait_for_stopped's initial ingest POST, which uses the no-retry http_request test helper, and flaked test_pipeline_error_dismissal in CI with a 503 PipelineInteractionUnreachable. This failure was observed in the CI run
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
mihaibudiu
approved these changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this the only test that may have this problem?
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. …le race start_pipeline()/resume_pipeline()/start_pipeline_as_paused() (wait=True) only wait for the control plane's deployment_status to report "running"; the pod itself can still be briefly unreachable through its k8s service afterward (the control plane's own readiness probe is a point-in-time check, not re-verified before the next caller's request). Calls through the SDK client already retry transient 503s, but tests/platform/helper.py's raw REST helpers are deliberately no-retry (other tests rely on that to see raw status codes), so they're exposed whenever they're the first pod-facing call after a start/resume. Add wait_for_pipeline_reachable(), which polls /stats until it stops returning 503 PipelineInteractionUnreachable, and call it at each of the 25 sites across 7 test files where that pattern occurs. test_pipeline_error.py (the one that actually flaked in CI) now uses the shared helper instead of its original bespoke retry loop. Signed-off-by: Ben Pfaff <[email protected]>
blp
force-pushed
the
retry-pipeline-error-test
branch
from
95126a4 to
5d950b9
Compare
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
mihaibudiu
approved these changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a dynamic check we could add to catch this if it's introduced in new tests?
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no need to mention the race here
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |