GeezerVison

bestouff left a comment

At startup, the pipeline now prints each key in its configuration file
that deserialization ignores, such as a misspelled setting.

serde_ignored cannot see keys inside #[serde(flatten)] structs, and
PipelineConfig flattens RuntimeConfig, so this uses a round trip: keys
that disappear on deserialize/serialize are probed with a value that no
setting accepts, which tells unknown keys apart from aliases and
skipped default values.

Signed-off-by: Ben Pfaff <[email protected]>

Messages from before logger initialization, such as unknown
configuration settings, went to stderr with eprintln!. Now they wait in
a queue and go to the logger, with a log level, once it is initialized.
If run_server returns before that, the queued messages, and the error
that stopped startup, go to stderr as before.

Signed-off-by: Ben Pfaff <[email protected]>

The order of ignored settings follows serde_json::Map.  Without the
preserve_order feature, keys are sorted.  With it, keys keep input
order.  The pipeline-manager crate enables preserve_order, so in a
workspace build the unknown_settings_are_ignored test got the keys in
input order and failed.  Now the test sorts the result, so it passes
either way.

Signed-off-by: Ben Pfaff <[email protected]>