GeezerVison is showing github.com — [python] Turn the commented-out window RANK tests into positive tests by 555aaditya · Pull Request #7678 · feldera/feldera
Conversation
555aaditya
commented
Oct 28, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Fixes #6226
test_window_agg.py had three negative tests commented out with "TODO: fix this test, it now should pass": RANK, DENSE_RANK and ROW_NUMBER over a constant ORDER BY, which the compiler used to reject outside a TopK pattern. All three are positive tests now.
Describe Manual Test Plan
Ran tests/runtime_aggtest/illarg_tests2/main.py against the pipeline-manager:0.372.0 image, which includes #7694, and it passes. To make sure each new view is actually checked, I broke the expected rows of the RANK and DENSE_RANK views one at a time. Each run failed on that view (failed view: illarg_window_rank_order_by_null, ... dense_rank_order_by_const). On the earlier run I did the same for the ROW_NUMBER view. pre-commit run on the file is clean.
Checklist
- Unit tests added/updated
- Integration tests added/updated
- Documentation updated
- Changelog updated
Breaking Changes?
- OpenAPI / REST HTTP API / feldera-types / manager
- Feldera SQL (Syntax, Semantics)
- feldera-sqllib (incl. dependencies fxp, etc.)
- Python SDK
- fda (CLI arguments)
- Adapters (including configuration)
- Storage Format / Checkpoints
- Others (specify)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Let's consider this after #7677 is fixed.
I marked it as draft until then; please request a review again.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
test_window_agg.py kept three negative tests commented out with "TODO:
fix this test, it now should pass": RANK, DENSE_RANK and ROW_NUMBER over
a constant ORDER BY, which the compiler used to reject outside a TopK
pattern and now accepts.
Turn all three into positive tests. With a constant ORDER BY every row
ties, so RANK and DENSE_RANK give every row 1. For ROW_NUMBER, which row
gets which number is unspecified, so that test checks only the numbers.
RANK and DENSE_RANK only compile since feldera#7694 (the fix for feldera#7677).
Fixes feldera#6226
Signed-off-by: 555aaditya <[email protected]>
|
#7677 is fixed by #7694, so all three tests are enabled now. They pass against v0.372.0. @mihaibudiu ready for another look.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|