GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [docs] Link the Kafka output delivery guarantees from the pages that need them by bestouff · Pull Request #7683 · feldera/feldera

Conversation

@bestouff

@bestouff bestouff commented Oct 28, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Linked Issue

Last step for #7578, stacked on #7682. Documentation only: links the Kafka sink's delivery, recovery and metrics sections from the pages a reader starts from.

Page Change
pipelines/fault-tolerance.md today only the Kafka output connector supports exactly-once output; link to its recovery section
operations/metrics.md.in, metrics.md output connectors can export metrics of their own; links to Kafka and Delta Lake
connectors/sinks/kafka.md the introduction links the delivery sections and the metrics table

Describe Manual Test Plan

Prose only. Every new anchor exists on its target page.

Checklist

  • Unit tests added/updated (not applicable)
  • Integration tests added/updated (not applicable)
  • Documentation updated
  • Changelog updated (landed with [connectors] Retain Kafka output through broker outages #7653 and [connectors] Replay the transaction in the exactly-once Kafka output #7682)

Breaking Changes?

None.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mythical-fred-oss

mythical-fred-oss Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

LGTM. This PR only changes docs, so the test gates don't apply. What I checked:

  • All three new anchors resolve on the Kafka sink page in the merged tree: #delivery-retries-and-backpressure, #exactly-once-delivery-and-recovery, #output-metrics.
  • The new metrics paragraph is the same in metrics.md.in and metrics.md, and it sits outside the {{output_connector_}} block, so regenerating metrics.md will keep it.
  • The claim that Kafka is the only exactly-once sink holds in the code. In crates/connectors, is_fault_tolerant() returns true only for kafka/ft and the null sink. Snowflake and Confluent JDBC count too, because they run on the Kafka output connector.
  • pre-commit run --files <4 changed files> passed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mihaibudiu
mihaibudiu approved these changes Oct 28, 2026
View reviewed changes
Comment thread docs.feldera.com/docs/operations/metrics.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread docs.feldera.com/docs/pipelines/fault-tolerance.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread docs.feldera.com/docs/pipelines/fault-tolerance.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bestouff
bestouff force-pushed the issue-7578-step4 branch from 1e41790 to 6c8fdf6 Compare October 28, 2026 18:49
@bestouff bestouff mentioned this pull request Oct 28, 2026
[connectors] Give transport output endpoints a health and metrics channel #7639
Merged
3 of 12 tasks
@bestouff
bestouff added this pull request to stack #7686 October 28, 2026 19:05
@bestouff
bestouff marked this pull request as ready for review October 28, 2026 19:17
@mythical-fred-oss

mythical-fred-oss Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

LGTM (docs only, stacked on #7682).

What I checked

  • Every new link target exists: kafka#delivery-retries-and-backpressure, #exactly-once-delivery-and-recovery, #output-metrics, and delta#metrics.
  • The claim "today only the Kafka output connector supports exactly-once output" holds in the code. is_fault_tolerant() returns true only for kafka/ft/output.rs, plus the null sink, which drops everything anyway. Delta, Postgres, NATS, Redis, S2, DynamoDB, file and HTTP all return false.
  • The metrics.md.in and metrics.md edits are identical, so regenerating with metrics.py keeps them in sync.
  • pre-commit run --files <4 changed files> passed.

Commit history (medium): the second commit, "Scope the exactly-once statement…", says it is review feedback. Please squash it into the first commit before merge, to keep main's history linear and clean.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bestouff
bestouff force-pushed the issue-7578-step4 branch from 7148c16 to e0f5a95 Compare October 28, 2026 19:31
@bestouff
bestouff force-pushed the issue-7578-step4 branch 2 times, most recently from 4f61f74 to 373bec8 Compare October 29, 2026 13:00
@bestouff
bestouff added this pull request to the merge queue Oct 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Oct 29, 2026
@bestouff
bestouff force-pushed the issue-7578-step4 branch from 373bec8 to 89c1f1b Compare October 29, 2026 15:40
@bestouff
bestouff added this pull request to the merge queue Oct 29, 2026
@bestouff
bestouff removed this pull request from the merge queue due to a manual request Oct 29, 2026
@mihaibudiu
mihaibudiu added this pull request to the merge queue Oct 30, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because the pull requests in the stack were not ordered correctly in the queue Oct 30, 2026
@mihaibudiu
mihaibudiu force-pushed the issue-7578-step4 branch from 89c1f1b to 6e244c6 Compare October 30, 2026 06:20
@mihaibudiu
mihaibudiu added this pull request to the merge queue Oct 30, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to invalid changes in the merge commit Oct 30, 2026
Base automatically changed from issue-7578-step3 to main October 30, 2026 10:05
@bestouff @mihaibudiu
[docs] Link the Kafka output delivery guarantees from the pages that …
6dcd479
…need them

The Kafka sink page now documents delivery, retries, backpressure, health,
exactly-once recovery and the connector's metrics, but the pages a reader
starts from did not point there. The fault tolerance page says that output
connectors document their own support, that today only the Kafka output
connector supports exactly-once output, and links its recovery section.
The metrics reference says that output connectors can export metrics of
their own and points at the Kafka and Delta Lake pages. The sink page's
introduction links its own delivery sections.

Fourth step for #7578, stacked on #7682.

Signed-off-by: Xavier Bestel <[email protected]>
@mihaibudiu
mihaibudiu force-pushed the issue-7578-step4 branch from 6e244c6 to 6dcd479 Compare October 30, 2026 10:05
@bestouff
bestouff added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 014fe10 Oct 30, 2026
1 check passed

Uh oh!

There was an error while loading. Please reload this page.

@bestouff
bestouff deleted the issue-7578-step4 branch October 30, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mihaibudiu mihaibudiu mihaibudiu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bestouff @mihaibudiu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.