GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [SQL] Update guava to latest version by mihaibudiu · Pull Request #7697 · feldera/feldera

Conversation

@mihaibudiu

@mihaibudiu mihaibudiu commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Guava now needs to pull another JAR; added it to the pom.xml

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mihaibudiu
[SQL] Update guava to latest version
ac0ff1c 
Signed-off-by: Mihai Budiu <[email protected]>
swanandx
swanandx approved these changes Oct 29, 2026
View reviewed changes
@mythical-fred-oss

mythical-fred-oss Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

LGTM.

What I ran

Step Result
./build.sh (compiler + Calcite) ✅
mvn dependency:tree guava 33.7.2 now brings in failureaccess and jspecify. It no longer brings in checker-qual, so pinning 4.3.1 directly is the right fix (the compiler sources import org.checkerframework in 54 places)
mvn test -Dtest=CastTests,BasicQueriesTests,CalciteSqlOperatorTest ✅ 147/147

Licenses are fine: guava is Apache-2.0 and checker-qual is MIT. Swapping Charsets.UTF_8 for StandardCharsets.UTF_8 changes no behaviour. No new tests are needed for a dependency bump.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mihaibudiu
mihaibudiu added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 462ef2e Oct 29, 2026
3 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@mihaibudiu
mihaibudiu deleted the guava branch October 29, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swanandx swanandx swanandx approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mihaibudiu @swanandx
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.