GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix several flaky tests by ryzhyk · Pull Request #7731 · feldera/feldera

Conversation

@ryzhyk

@ryzhyk ryzhyk commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Address several recent CI failures.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
ryzhyk added 4 commits October 29, 2026 22:51
@ryzhyk
[connectors] Cancel the Delta commit-loop test only after its write r…
31b697d
…eturns

`a_shutdown_ends_an_unbounded_commit_loop` now waits for `encode` to return before the 200 ms
pause that precedes its shutdown.

The test cancelled 200 ms after starting the committer thread, assuming the write had finished
by then. In a debug build on a busy test runner it had not, so the shutdown aborted the write
itself ("Delta table write aborted after 0 attempts: the pipeline is shutting down") and the test
failed at its check that the write succeeds.

The committer thread signals between `encode` and `batch_end`, so the shutdown lands in the
commit loop, which is what the test checks. Both calls still run on that thread, so a hang in
either fails the test rather than hanging the run.

Signed-off-by: Leonid Ryzhyk <[email protected]>
@ryzhyk
[connectors] Give delta_table_output_test's pipeline the suites' defa…
2b03167
…ult wait

`delta_table_output_test` now waits up to `default_timeout_ms` (600 s, or `FELDERA_TEST_WAIT_MS`)
for its pipeline to complete, instead of 100 s, and its timeout says what it waited for.

The output proptests that call it draw up to 20,000 rows. In a debug build on a busy test runner,
an 18,620-row draw took longer than 100 s, and the case failed although the pipeline was only
slow.

The limit is the suites' default, the one `wait_for_records_materialized` uses, so a run that
lowers `FELDERA_TEST_WAIT_MS` shortens this wait as well.

Signed-off-by: Leonid Ryzhyk <[email protected]>
@ryzhyk
[dbsp] Look in the cache again after a read-ahead claims its block
ecc149d
When an earlier read-ahead of the same block finished between the look in
the cache and the claim, the claim succeeded and the block was read a
second time.  This made
`a_walk_that_overtakes_its_read_ahead_waits_rather_than_reading_twice`
flaky.  `DataBlock::new` already looks again after its claim.

Signed-off-by: Leonid Ryzhyk <[email protected]>
@ryzhyk
[dbsp] Drop the clippy::borrow_deref_ref allows from storage::file::r…
6563295
…eader

Four of the five sat on `&*` of an `Arc<dyn FileReader>`, which the lint
does not flag.  The fifth covered a no-op reborrow of a `&dyn FileReader`
in `FileTrailer::new`, which now passes the reference itself.

Signed-off-by: Leonid Ryzhyk <[email protected]>
@mythical-fred-oss

mythical-fred-oss Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

LGTM.

Ran Result
cargo test -p dbsp --lib a_walk_that_overtakes ×100 100/100 pass
cargo test -p dbsp --lib read_ahead 4/4 pass
cargo clippy -p dbsp --lib --tests (with the borrow_deref_ref allows removed) clean
static-connectors --test connector_suites a_shutdown_ends (commit loop ×30) all pass
delta_table::test::file_output_proptest (both variants, debug build) pass, 61 s
rustfmt --check on the changed files clean

The extra cache check in read_ahead closes the claim race the same way DataBlock::new does, and the claim is dropped on continue, so no slot leaks. None of the gates fail: these are test-only and race fixes, with no user-visible change and no new dependencies.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mihaibudiu
mihaibudiu approved these changes Oct 30, 2026
View reviewed changes
gz
gz approved these changes Oct 30, 2026
View reviewed changes
@gz
gz added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit f5c129a Oct 30, 2026
3 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@gz
gz deleted the fix-delta-output-test-flakes branch October 30, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gz gz gz approved these changes
@mihaibudiu mihaibudiu mihaibudiu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ryzhyk @gz @mihaibudiu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.