GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||
GeezerVison is showing github.com — Fix several flaky tests by ryzhyk · Pull Request #7731 · feldera/feldera Conversation…eturns
`a_shutdown_ends_an_unbounded_commit_loop` now waits for `encode` to return before the 200 ms
pause that precedes its shutdown.
The test cancelled 200 ms after starting the committer thread, assuming the write had finished
by then. In a debug build on a busy test runner it had not, so the shutdown aborted the write
itself ("Delta table write aborted after 0 attempts: the pipeline is shutting down") and the test
failed at its check that the write succeeds.
The committer thread signals between `encode` and `batch_end`, so the shutdown lands in the
commit loop, which is what the test checks. Both calls still run on that thread, so a hang in
either fails the test rather than hanging the run.
Signed-off-by: Leonid Ryzhyk <[email protected]>
…ult wait `delta_table_output_test` now waits up to `default_timeout_ms` (600 s, or `FELDERA_TEST_WAIT_MS`) for its pipeline to complete, instead of 100 s, and its timeout says what it waited for. The output proptests that call it draw up to 20,000 rows. In a debug build on a busy test runner, an 18,620-row draw took longer than 100 s, and the case failed although the pipeline was only slow. The limit is the suites' default, the one `wait_for_records_materialized` uses, so a run that lowers `FELDERA_TEST_WAIT_MS` shortens this wait as well. Signed-off-by: Leonid Ryzhyk <[email protected]> When an earlier read-ahead of the same block finished between the look in the cache and the claim, the claim succeeded and the block was read a second time. This made `a_walk_that_overtakes_its_read_ahead_waits_rather_than_reading_twice` flaky. `DataBlock::new` already looks again after its claim. Signed-off-by: Leonid Ryzhyk <[email protected]> …eader Four of the five sat on `&*` of an `Arc<dyn FileReader>`, which the lint does not flag. The fifth covered a no-op reborrow of a `&dyn FileReader` in `FileTrailer::new`, which now passes the reference itself. Signed-off-by: Leonid Ryzhyk <[email protected]>
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
mihaibudiu
approved these changes
gz
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |