GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||
GeezerVison is showing github.com — [SQL] Compare MAP_CONTAINS_KEY's key with the map's keys in a common type by gz · Pull Request #7740 · feldera/feldera Conversation
Contributor
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…type MAP_CONTAINS_KEY(MAP[ARRAY[1], ARRAY[2]], a) with a INT ARRAY passed an array of nullable INT where the map's keys are arrays of INT NOT NULL, and the Rust code failed to compile with "mismatched types". The key and the map are now cast to a common key type, as ARRAY_CONTAINS does for its element. That map cast moved an array or map element out of its reference; the element converter now clones it, as it already cloned a base-type element. Signed-off-by: Gerd Zellweger <[email protected]>
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bug (medium): ROW keys still fail to compile with "mismatched types", but now the failure is in the result type rather than the key.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This looks like a good point to address.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
mihaibudiu
requested changes
MAP_CONTAINS_KEY(MAP[ROW(1, 2), 1], ROW(1, NULLIF(2, 0))) failed to compile with "mismatched types": Calcite infers a nullable BOOLEAN when a ROW argument has a nullable field, but map_contains_key__ returns bool for a non-null map and key. The call now has the nullability of its arguments and is cast to Calcite's type, as ARRAY_CONTAINS does. testMapContainsKey covers ROW and nested ARRAY keys, and testMapContainsKeyTable takes the keys from table columns. Signed-off-by: Gerd Zellweger <[email protected]>
mihaibudiu
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||||||||||||||||||
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |