GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [profiler] Do not draw the edges into the multihost remote waiter by mihaibudiu · Pull Request #7771 · feldera/feldera

Conversation

@mihaibudiu

@mihaibudiu mihaibudiu commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Linked Issue

Fixes #7243

Ignore all in-edges to a node with operation ShardedAccumulatorRemoteWaiter when drawing a profile.

Describe Manual Test Plan

Ran the profiler manually

Checklist

  • Unit tests added/updated

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ryzhyk reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@mihaibudiu
[profiler] Do not draw the edges into the multihost remote waiter
613b8f3 
Signed-off-by: Mihai Budiu <[email protected]>
@mihaibudiu
mihaibudiu requested a review from ryzhyk November 1, 2026 06:47
@mythical-fred-oss

mythical-fred-oss Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

LGTM.

Checked the edge direction against add_sharded_accumulator_receiver in crates/dbsp/src/operator/dynamic/sharded_accumulator.rs. Each receiver gets add_dependency(receiver, remote_waiter), so the edges point receiver → waiter. Dropping the edges whose target is the waiter therefore removes all of them. Splitting the label on @ and calling trim() works whether or not the label has a location suffix.

Ran Result
vitest --run src/profile.test.ts 168/168 pass
New test with the profile.ts change reverted fails as expected, so the test guards the fix
Full profiler-lib vitest --run 2 failures in viewport.test.ts (zoom 1 vs 0.9375). These also fail without this PR's change, so they are not caused by it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ryzhyk
ryzhyk approved these changes Nov 2, 2026
View reviewed changes
@mihaibudiu
mihaibudiu added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit 288cd64 Nov 2, 2026
3 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@mihaibudiu
mihaibudiu deleted the issue7243 branch November 2, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryzhyk ryzhyk ryzhyk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[profiler] Profiler issues on multihost

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mihaibudiu @ryzhyk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.