GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add rclone to our devcontainer and Docker image by llogiq · Pull Request #7774 · feldera/feldera

Conversation

@llogiq

@llogiq llogiq commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

This is just a small addition to our Dockerfiles, to aid a change in the cloud repo.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Karakatiza666 reacted with heart emoji
All reactions
  • ❤️ 1 reaction
mythical-fred-oss[bot]
mythical-fred-oss Bot reviewed Nov 1, 2026
View reviewed changes
Comment thread deploy/Dockerfile Resolved

Uh oh!

There was an error while loading. Please reload this page.
mythical-fred-oss[bot]
mythical-fred-oss Bot reviewed Nov 1, 2026
View reviewed changes
Comment thread deploy/Dockerfile Outdated
# Used to set capabilities to the samply profiler
libcap2-bin
libcap2-bin \
# rclone is used by cloud's sync-checkpoint crate

@mythical-fred-oss mythical-fred-oss Bot Nov 1, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pitfall (medium): Ubuntu 24.04's apt rclone is 1.60.x, from late 2022. Please check that the flags the checkpoint-sync code passes (see extra flags / S3 / GCS options in crates/feldera-types/src/config.rs) work on that version. If they don't, pin a newer release by downloading the official .deb with a checksum. A newer build also helps with the FIPS rule: the distro's Go build uses Go's own crypto/TLS rather than aws-lc, so please confirm that's acceptable for the shipped image.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@llogiq llogiq Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. There are two options that are unsupported in 1.60. I'll change the images to include a current version instead.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mythical-fred-oss

mythical-fred-oss Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Review summary

Check Result
sh -n on the changed RUN snippet in deploy/Dockerfile ❌ fails: unterminated quote (see inline)
Docker build not run (no Docker daemon here)
.devcontainer/Dockerfile change ✅ looks fine
Licensing ✅ rclone is MIT
  • bug (critical): the stray ' in deploy/Dockerfile breaks the image build. Please don't merge until it's fixed and the docker CI job passes.
  • missing (medium), manual testing: the PR description doesn't say how this was checked. Please confirm that the built image runs rclone version and that the rclone version Ubuntu ships works with the checkpoint-sync flags (see inline).
  • pitfall (low/medium): rclone adds roughly 50–60 MB to the shipped OSS image only so a downstream image can use it. Consider installing it in that downstream image instead, or say in the commit message why the OSS image needs it.
  • commit message: the subject should be capitalized: Add rclone to devcontainer and Docker image.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gz
gz approved these changes Nov 1, 2026
View reviewed changes
@llogiq
llogiq force-pushed the rclone branch 2 times, most recently from cdd2189 to 92d335c Compare November 1, 2026 16:55
@llogiq llogiq changed the title add rclone to our devcontainer and docker image Add rclone to our devcontainer and Docker image Nov 1, 2026
@llogiq
llogiq added this pull request to the merge queue Nov 1, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 1, 2026

Uh oh!

There was an error while loading. Please reload this page.
@llogiq
llogiq added this pull request to the merge queue Nov 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 2, 2026

Uh oh!

There was an error while loading. Please reload this page.
@llogiq
llogiq force-pushed the rclone branch from 92d335c to 806cf00 Compare November 2, 2026 14:45
@llogiq
add rclone to our devcontainer and docker image
cc3bb2e
@llogiq
llogiq force-pushed the rclone branch from 806cf00 to cc3bb2e Compare November 2, 2026 14:47
@llogiq
llogiq added this pull request to the merge queue Nov 2, 2026
@gz

gz commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

please see https://github.com/feldera/cloud/wiki/Continuous-Integration#i-need-to-update-an-existing-or-use-a-new-tool-in-ci for follow up work
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Merged via the queue into main with commit 4b6d3b4 Nov 2, 2026
1 check passed

Uh oh!

There was an error while loading. Please reload this page.
@llogiq
llogiq deleted the rclone branch November 2, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mythical-fred-oss mythical-fred-oss[bot] mythical-fred-oss[bot] left review comments
@gz gz gz approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@llogiq @gz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.