GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [docs] Document pipeline.allowLocalFileUris by swanandx · Pull Request #7780 · feldera/feldera

Conversation

@swanandx

@swanandx swanandx commented Nov 2, 2026

Copy link
Copy Markdown
Member

Adds pipeline.allowLocalFileUris to the Helm chart reference. The option refuses local paths in Delta Lake and Iceberg connectors.

Linked Issue

None.

Describe Manual Test Plan

Docs only. The text matches the chart behavior in 0.373.0.

Checklist

  • Unit tests added/updated
  • Integration tests added/updated
  • Documentation updated
  • Changelog updated

Breaking Changes?

Mark if you think the answer is yes for any of these components:

  • OpenAPI / REST HTTP API / feldera-types / manager (What is a breaking change?)
  • Feldera SQL (Syntax, Semantics)
  • feldera-sqllib (incl. dependencies fxp, etc.) (What is a breaking change?)
  • Python SDK (What is a breaking change?)
  • fda (CLI arguments)
  • Adapters (including configuration)
  • Storage Format / Checkpoints
  • Others (specify)

Describe Incompatible Changes

None.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@swanandx
[docs] Document pipeline.allowLocalFileUris
cd942c1
The Helm chart has this option since 0.373.0, but the Helm reference did not list it.

Signed-off-by: Swanand Mulay <[email protected]>
@swanandx
swanandx requested a review from gz November 2, 2026 08:26
@mythical-fred-oss

mythical-fred-oss Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

LGTM. This is a docs-only change, so the test gates don't apply.

What I ran

  • pre-commit run --files helm-chart-reference.md passed.
  • cargo test -p feldera-types local_file_uri passed.
  • I checked the new row against TransportConfig::local_file_uris and resolve_connector_config in crates/connectors/src/controller.rs. The row matches what the code does:
    • Covered connectors: Delta input and output (uri), and Iceberg input (metadata_location, glue.warehouse).
    • What counts as local: a file: URL or a value with no scheme.
    • When it applies: the connector fails when it is created, and the check also runs on values that come from secrets.
  • The Helm chart isn't in this repo, so I couldn't confirm the true default or that the chart maps the option to FELDERA_REFUSE_LOCAL_FILE_URIS.

missing (medium): docs/connectors/sources/iceberg.md:110 still lists file:// / no prefix as supported, and the Delta pages don't mention the restriction. Users on a locked-down deployment will hit a startup error that those pages don't explain. A one-line note on each page linking to this Helm option, and naming the env var for deployments that don't use Helm, would close that gap.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@swanandx
swanandx enabled auto-merge November 2, 2026 14:37
gz
gz approved these changes Nov 2, 2026
View reviewed changes
@swanandx
swanandx disabled auto-merge November 2, 2026 18:29
@swanandx
swanandx added this pull request to the merge queue Nov 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 2, 2026

Uh oh!

There was an error while loading. Please reload this page.

@swanandx
swanandx added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit df49e3b Nov 3, 2026
3 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@swanandx
swanandx deleted the docs-allow-local-file-uris branch November 3, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gz gz gz approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@swanandx @gz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.